frozen_string_literal roadmap

[janklimo]

Ryan, thank you for your work on this gem!

I'd like to ask if frozen_string_literal support is on the roadmap? I just ran memory profiler on one of our scripts and saw this:

Some more details:

I haven't looked into this much and I'm not perfectly sure if frozen_string_literal can help in our case, just wanted to open a conversation to see what your thoughts on it are. Thanks!

[rgrove]

I'm definitely open to it. I haven't had much free time lately though, so I can't promise I'll be able to get to it soon myself. I'd welcome a PR!

[flavorjones]

See PR at #174. Hope it helps!

[rgrove]

Awesome! Thanks Mike. 😄

Merged and released 4.6.1. @janklimo, I'd be interested to hear if running with frozen string literals enabled solves your memory usage issues.

[janklimo]

@rgrove I looked into this and I'm afraid this won't help with the way strings are allocated in my example above. The line in question is this one:

sanitize/lib/sanitize.rb

Line 225 in 184709b

:node_name => node.name.downcase,

I'm not sure if there is a way to optimize the way this keeps allocating lots of identical strings. But those are not string literals, so enabling frozen_string_literal makes no difference.

However, it's great to make sanitize frozen_string_literal-friendly. Thank you @flavorjones lightning-fast response time 🚀👍 Closing.

EDIT: I have an optimization in mind and the results are promising so far. I hope to have a PR ready tomorrow.