Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin Nokogumbo version #141

Merged
merged 1 commit into from
Dec 9, 2015
Merged

Unpin Nokogumbo version #141

merged 1 commit into from
Dec 9, 2015

Conversation

rubys
Copy link
Contributor

@rubys rubys commented Dec 9, 2015

Is there a reason that you have limited the nokogumbo version to exactly 1.4.1? Is there a change (either in code or in process) that would enable updated versions to be used?

Is there a reason that you have limited the nokogumbo version to _exactly_ 1.4.1?  Is there a change (either in code or in process) that would enable updated versions to be used?
@rgrove
Copy link
Owner

rgrove commented Dec 9, 2015

I started pinning the Nokogumbo version in commit 9513c97 after a broken Nokogumbo patch release caused problems for Sanitize users. Nokogumbo's been pretty stable since then though, so we can probably stop pinning if you pinky-swear not to break it again. 😉

@rgrove rgrove merged commit ff9db83 into rgrove:master Dec 9, 2015
@rubys
Copy link
Contributor Author

rubys commented Dec 9, 2015

I can't promise not to break it again; but I will promise to promptly fix or revert any commit that causes problems for sanitize.

@rgrove
Copy link
Owner

rgrove commented Dec 9, 2015

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants