Optimize Sanitize#transform_node! #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since transform_node! may be called in a tight loop to process thousands of items, we can optimize both memory and CPU performance by: 1. Reusing the same config hash for each transformer 2. Directly assigning values to hash instead of using merge!. Not only does merge! create a new hash, it is also 2.6x slower: https://github.com/JuanitoFatas/fast-ruby#hashmerge-vs-hash-code
stanhu
force-pushed
the
sh-optimize-transform-node
branch
from
93e5196
to
5fb40a7
Compare
|
Latest benchmarks on Ruby 2.4.4: |
|
Nice! Thanks. 👍 |
swills
pushed a commit
to swills/gitlabhq
that referenced
this pull request
Aug 1, 2018
sanitize 4.6.6 has this optimization that will benefit Markdown rendering: rgrove/sanitize#183 nokogiri 1.4.4 has this memory leak fix: sparklemotion/nokogiri#1771
jameszhan
pushed a commit
to jameszhan/gitaly
that referenced
this pull request
Nov 13, 2018
sanitize 4.6.6 has this optimization that will benefit Markdown rendering: rgrove/sanitize#183 nokogiri 1.4.4 has this memory leak fix: sparklemotion/nokogiri#1771 This mirrors changes for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20795.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since transform_node! may be called in a tight loop to process thousands
of items, we can optimize both memory and CPU performance by:
merge! create a new hash, it is also 2.6x slower:
https://github.com/JuanitoFatas/fast-ruby#hashmerge-vs-hash-code
Here's a sample before:
After: