Add #distance and #angular_size to Sun
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the Sun's true anomaly available, it is convenient to compute the Earth-Sun distance and the Sun's apparent angular size. The distance is of course an approximation. It is returned in meters as it is a SI unit, but it must not be seen as a value precise by the meter. For example, it doesn't count the observer's elevation or height. Note that in the tests added, the precision for these two values taken from books examples weren't as high as in the tests. Therefore, the reader won't find matching results from the books. Also, these values will likely be updated as the precision of the library increases, which is acceptable as they weren't that close to the book examples in the first place.
rhannequin
added a commit
that referenced
this pull request
Mar 24, 2024
## 0.2.0 - 2024-03-24 _If you are upgrading: please see [`UPGRADING.md`]._ [`UPGRADING.md`]: https://github.com/rhannequin/astronoby/blob/main/UPGRADING.md ### Features * Angle comparison ([#21]) * Add `#distance` and `#angular_size` to `Astronoby::Sun` ([#30]) * Add geocentric parallax `Astronoby::GeocentricParallax` ([#31]) * Ability to calculate equinoxes and solstices times ([#32]) * Round rising and setting times to the second ([#38]) * Provide sunrise and sunset times ([#35]) * Provide sunrise and sunset azimuths ([#39]) * Ability to calculate the equation of time ([#40]) ### Breaking changes * **breaking:** Accurate setting and rising times for punctual bodies ([#29]) * **breaking:** Drop `Astronoby::Util::Time` in favor of `Astronoby::GreenwichSiderealTime` and `Astonoby::LocalSiderealTime` ([#36]) ### Improvements * Add Dependabot for Bundler and GitHub Actions ([#24]) * Add bundler-audit GitHub Action ([#25]) * Bump actions/checkout from 3 to 4 ([#26]) * Bump standard from 1.29.0 to 1.35.1 ([#27], [#37]) * Bump rspec from 3.12.0 to 3.13.0 ([#28]) [#21]: #21 [#24]: #24 [#25]: #25 [#26]: #26 [#27]: #27 [#28]: #28 [#29]: #29 [#30]: #30 [#31]: #31 [#32]: #32 [#35]: #35 [#36]: #36 [#37]: #37 [#38]: #38 [#39]: #39 [#40]: #40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the Sun's true anomaly available, it is convenient to compute the Earth-Sun distance and the Sun's apparent angular size.
The distance is of course an approximation. It is returned in meters as it is a SI unit, but it must not be seen as a value precise by the meter. For example, it doesn't count the observer's elevation or height.
Note that in the tests added, the precision for these two values taken from books examples weren't as high as in the tests. Therefore, the reader won't find matching results from the books. Also, these values will likely be updated as the precision of the library increases, which is acceptable as they weren't that close to the book examples in the first place.