Allow writing and reading null values #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansman
commented
Oct 24, 2016
| writeMethod.addStatement("$N.beginObject()", jsonWriter); | ||
| for (Map.Entry<Property, FieldSpec> entry : adapters.entrySet()) { | ||
| Property prop = entry.getKey(); | ||
| FieldSpec field = entry.getValue(); | ||
|
|
||
| if (prop.nullable()) { |
There was a problem hiding this comment.
I considered using nullValue() instead of letting the adapter handle it but adapters should handle null values according to the documentation:
Type adapters should be prepared to read null from the stream and write it to the stream. Alternatively, they should use nullSafe() method while registering the type adapter with Gson.
ansman
commented
Oct 24, 2016
| @@ -392,12 +394,6 @@ public MethodSpec createReadMethod(ClassName className, | |||
| FieldSpec name = FieldSpec.builder(String.class, "_name").build(); | |||
| readMethod.addStatement("$T $N = $N.nextName()", name.type, name, jsonReader); | |||
|
|
|||
| // check if JSON field value is NULL | |||
There was a problem hiding this comment.
Removing this has two resulting effects:
- If the resulting JSON contains a
nullvalue for a field that isn't nullable the serialization will fail. - If the resulting JSON contains a
nullvalue for a primitive the serialization will fail. - The adapters now get a chance to handle
nullvalues if they want to.
All of these seems like the behaviour you'd want.
This closes rharter#23, rharter#50 and rharter#67
|
LGTM 👍 |
This was referenced Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #23, #50 and #67