cockpit-storage-integration: move storage check steps to custom hook with step handling #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
force-pushed
the
disk-selection-set-race-backend-v2
branch
from
b097ea8 to
2df2529
Compare
KKoukiou
changed the title
Ensure the disk selection logic runs only once after re-scanning disks. Previously, if the disk names changed (e.g., a new MD array name), the selection code would re-run due to its dependency on `selectedDisks` inside `useEffect`. To prevent this, get the selectedDisks from the API directly inside the useEffect to avoid getting this from outside and causing useEffect re-runs. Note: I created a followup ticket to re-approach how we do the storage checks in this file: https://issues.redhat.com/browse/INSTALLER-4162, as I realize this has grown out of its original architecture. Resolves: rhbz#2354798
…with step handling This ensures that steps are run only once.
KKoukiou
force-pushed
the
disk-selection-set-race-backend-v2
branch
from
2df2529 to
211d902
Compare
…ration steps fail
… destructive Let it be called multiple times. Also do not perform any step when storage is being fetched.
KKoukiou
force-pushed
the
disk-selection-set-race-backend-v2
branch
from
40245c7 to
fa61da7
Compare
rvykydal
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.