Do not mark ancestors of device with source or stage2 as protected #5687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kickstart-test --testtype smoke |
vojtechtrefny
approved these changes
Jun 18, 2024
jkonecny12
requested changes
Jun 19, 2024
| @@ -285,6 +285,7 @@ def _mark_protected_devices(self): | |||
| identify protected devices. | |||
| """ | |||
| protected = [] | |||
| protected_w_ancestors = [] | |||
There was a problem hiding this comment.
I wonder what w means here. Is it with or without? I would like to not use this abbreviations.
| @@ -353,23 +358,31 @@ def protect_devices(self, protected_names): | |||
| # Update the list. | |||
| self.protected_devices = protected_names | |||
|
|
|||
| def _mark_protected_device(self, device): | |||
| def _mark_protected_device(self, device, ancestors=False): | |||
There was a problem hiding this comment.
Could we please name the boolean to make it's obvious it's not a list of ancestors. I would suggest protect_ancestors or include_ancestors?
|
|
||
| def _mark_unprotected_device(self, device): | ||
| def _mark_unprotected_device(self, device, ancestors=False): |
Resolves: RHEL-35701 I am not able to find any reason why we started to protect also ancestors of the devices in this case (ie disk in case of source on a partition). The change (marking also ancestors of protected devices as protected in general) was introduced during modularization of Payload. commit 93fdbff commit 26de57d commit 19703fc commit 71dda92 The patch tries to limit the changes to the case of the issue. From what I was able to look at it seems that it should be OK not to include ancestors also in other cases.
rvykydal
force-pushed
the
rhel-35701-hdd-protecting-ancestor-upstream
branch
from
fa67045
to
4779d5f
Compare
|
/kickstart-test --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.