-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add harddrive-iso-single test and "harddrive" tests updates #1210
Conversation
/test-os-variants |
1 similar comment
/test-os-variants |
2e39799
to
2a03745
Compare
/test-os-variants |
/test-os-variants --testtype harddrive |
/test-os-variants |
@jkonecny12 Could you please take a look at the PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
pre-lib-harddrive.sh
Outdated
local disk="$1" | ||
|
||
sgdisk --zap-all ${disk} | ||
sgdisk --new=0:0:+12GiB ${disk} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the partition size be also increased to 22GiB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, let me check, we should probably parametrize the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I guess we need the unallocated space for autopart. Daily-iso failed on it when I increased it to 21GB: https://github.com/rhinstaller/kickstart-tests/actions/runs/9692991184
746652a
to
bd18e5e
Compare
/test-os-variants --testtype harddrive |
/test-os-variants |
97ad30b
to
79eb3b6
Compare
/test-os-variants harddrive-iso-single |
I am removing disabling on fedora as the upstream patch rhinstaller/anaconda#5687 is already merged (daily-iso should pass, rawhide still fail) |
Tests installation to single disk of which one partition is used to store hhd installation source.
Disable harddrive-iso-single on rhel10 until gh#1213 is fixed.
The tests use repository from the DVD.
We already use this tag for repo-addrepo-hd-tree and repo-addrepo-hd-iso.
On rhel 9 the dvd iso has ~11 GB.
84d28dd
to
179676c
Compare
/test-os-variants |
Indeed: https://github.com/rhinstaller/kickstart-tests/actions/runs/9695026372 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
No description provided.