Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add harddrive-iso-single test and "harddrive" tests updates #1210

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

rvykydal
Copy link
Contributor

No description provided.

@rvykydal
Copy link
Contributor Author

/test-os-variants

1 similar comment
@rvykydal
Copy link
Contributor Author

/test-os-variants

@rvykydal rvykydal force-pushed the hdd-part-test branch 3 times, most recently from 2e39799 to 2a03745 Compare May 31, 2024 07:40
@rvykydal
Copy link
Contributor Author

/test-os-variants

@rvykydal
Copy link
Contributor Author

/test-os-variants --testtype harddrive

@rvykydal
Copy link
Contributor Author

/test-os-variants

@rvykydal rvykydal marked this pull request as ready for review June 3, 2024 06:34
@rvykydal rvykydal requested a review from jkonecny12 June 3, 2024 06:34
@rvykydal rvykydal changed the title Hdd part test Add harddrive-iso-single test and "harddrive" tests updates Jun 3, 2024
@rvykydal
Copy link
Contributor Author

@jkonecny12 Could you please take a look at the PR ?

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

local disk="$1"

sgdisk --zap-all ${disk}
sgdisk --new=0:0:+12GiB ${disk}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the partition size be also increased to 22GiB?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, let me check, we should probably parametrize the function.

Copy link
Contributor Author

@rvykydal rvykydal Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I guess we need the unallocated space for autopart. Daily-iso failed on it when I increased it to 21GB: https://github.com/rhinstaller/kickstart-tests/actions/runs/9692991184

@rvykydal rvykydal force-pushed the hdd-part-test branch 2 times, most recently from 746652a to bd18e5e Compare June 27, 2024 08:08
@rvykydal
Copy link
Contributor Author

/test-os-variants --testtype harddrive

@rvykydal
Copy link
Contributor Author

/test-os-variants

@rvykydal rvykydal force-pushed the hdd-part-test branch 2 times, most recently from 97ad30b to 79eb3b6 Compare June 27, 2024 10:18
@rvykydal
Copy link
Contributor Author

/test-os-variants harddrive-iso-single

@rvykydal
Copy link
Contributor Author

rvykydal commented Jun 27, 2024

I am removing disabling on fedora as the upstream patch rhinstaller/anaconda#5687 is already merged (daily-iso should pass, rawhide still fail)

Tests installation to single disk of which one partition is used to
store hhd installation source.
Disable harddrive-iso-single on rhel10 until gh#1213 is fixed.
The tests use repository from the DVD.
We already use this tag for repo-addrepo-hd-tree and repo-addrepo-hd-iso.
On rhel 9 the dvd iso has ~11 GB.
@rvykydal rvykydal force-pushed the hdd-part-test branch 2 times, most recently from 84d28dd to 179676c Compare June 27, 2024 10:33
@rvykydal
Copy link
Contributor Author

/test-os-variants

@rvykydal rvykydal requested a review from jstodola June 27, 2024 10:44
@rvykydal
Copy link
Contributor Author

I am removing disabling on fedora as the upstream patch rhinstaller/anaconda#5687 is already merged (daily-iso should pass, rawhide still fail)

Indeed: https://github.com/rhinstaller/kickstart-tests/actions/runs/9695026372

Copy link
Contributor

@jstodola jstodola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@rvykydal rvykydal merged commit 2d4430e into rhinstaller:master Jun 28, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants