Skip to content

Conversation

simonpasquier
Copy link
Contributor

The page isn't really up-to-date. Also removed sthaha from the list of maintainers.

@simonpasquier simonpasquier requested a review from a team as a code owner September 11, 2024 14:15
@simonpasquier simonpasquier requested review from sthaha and slashpai and removed request for a team September 11, 2024 14:15
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 11, 2024

@simonpasquier: This pull request references COO-356 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

The page isn't really up-to-date. Also removed sthaha from the list of maintainers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier simonpasquier force-pushed the COO-356 branch 3 times, most recently from d4914cf to 8e4b4c6 Compare September 11, 2024 15:27
@simonpasquier
Copy link
Contributor Author

/cc @danielmellado

Comment on lines -862 to -772
- email: sthaha@redhat.com
name: Sunil Thaha
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the light of this change, should

publisher: Sunil Thaha
point to the team instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't apply for the productized version because the operator is shipped via the Red Hat catalog but I can fix in a following PR.

@danielmellado
Copy link
Contributor

This seems to have a trivial conflict in the csv version, @simonpasquier mind rebasing this? I'll get it in afterwards ;)

@simonpasquier
Copy link
Contributor Author

rebased

The page isn't really up-to-date. Also removed sthaha from the list of
maintainers.

Closes COO-356

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier
Copy link
Contributor Author

rebased again

@rexagod
Copy link
Member

rexagod commented Sep 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 42cb1b7 into rhobs:main Sep 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants