Skip to content

Conversation

jgbernalp
Copy link
Contributor

This PR uses the plugin names the console expect so the routing for resources and proxies works correclty

@jgbernalp jgbernalp requested a review from a team as a code owner October 7, 2024 09:57
@jgbernalp jgbernalp requested review from simonpasquier and JoaoBraveCoding and removed request for a team October 7, 2024 09:57
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 7, 2024

@jgbernalp: This pull request references COO-451 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

This PR uses the plugin names the console expect so the routing for resources and proxies works correclty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from machine424 and tremes October 7, 2024 09:57
Copy link

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@simonpasquier
Copy link
Contributor

/hold

@simonpasquier
Copy link
Contributor

/hold cancel

@openshift-merge-bot openshift-merge-bot bot merged commit 3dbb0f6 into rhobs:main Oct 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants