COO-1248: fix: use apiReader for correct ui plugin registration

[jgbernalp]

This PR:

• fixes the empty response when reading the cluster.console.operator.openshift.io, this is caused from reading from the cache when using the k8sClient. As the cluster plugins is read occasionally we can use the apiReader to get latest results.
• Fixes the names of some role bindings so labels are valid

[openshift-ci-robot]

@jgbernalp: This pull request references COO-1248 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jgbernalp: This pull request references COO-1248 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

This PR:

• fixes the empty response when reading the cluster.console.operator.openshift.io, this is caused from reading from the cache when using the k8sClient. As the cluster plugins is read occasionally we can use the apiReader to get latest results.
• Fixes the names of some role bindings so labels are valid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[andreasgerstmayr]

* Fixes the names of some role bindings so labels are valid

Does the operator remove the (old) role bindings with the previous name during the upgrade?

[jgbernalp]

* Fixes the names of some role bindings so labels are valid

Does the operator remove the (old) role bindings with the previous name during the upgrade?

No, good point. I'll create a follow up PR to fix this.

[openshift-ci]

@andreasgerstmayr: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreasgerstmayr, jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controllers/uiplugin/OWNERS [jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[PeterYurkovich]

/lgtm

[zhuje]

/lgtm

[jgbernalp]

/test observability-operator-e2e

[zhuje]

/retest

[zhuje]

observability-operator-e2e seems like a flaky test, it's been failing for a lot of the PRs, and the errors seem unrelated to the PR code.

If it fails a 3rd rerun, I'll override the test to pass and unblock this PR.

[zhuje]

/retest

[zhuje]

/override ci/prow/observability-operator-e2e

[openshift-ci]

@zhuje: zhuje unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

/override ci/prow/observability-operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[zhuje]

Found out I'm unauthorized to override the test. Only maintainers can override.

[zhuje]

/test observability-operator-e2e

[zhuje]

@rhobs/observability-operator-maintainers Can a maintainer /override ci/prow/observability-operator-e2e ? The test seems like it's been flaky lately. The errors seem unrelated to the PR code, and we've rerun it three times, but it still failed 😓

After, could I get a seperate /override ci/prow/observability-operator-e2e for this dependent PR: #884

maintainers:
- jan--f
- danielmellado
- simonpasquier
- slashpai
- marioferh
- jgbernalp
- lihongyan1

[jgbernalp]

/override ci/prow/observability-operator-e2e

[openshift-ci]

@jgbernalp: Overrode contexts on behalf of jgbernalp: ci/prow/observability-operator-e2e

In response to this:

/override ci/prow/observability-operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.