Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev installation section #6

Closed
wants to merge 2 commits into from
Closed

Add dev installation section #6

wants to merge 2 commits into from

Conversation

G07cha
Copy link
Contributor

@G07cha G07cha commented Oct 8, 2015

Guide to setup app for development but for now I've expecting issue when using npm start command.

Please, don't merge it until #7 don't be fixed

@rhysd
Copy link
Owner

rhysd commented Oct 8, 2015

Did you really try this sequence? I think rake build is needed to compile TypeScript codes. Please confirm that the sequence succeeds at least in your environment before sending pull request.

@G07cha
Copy link
Contributor Author

G07cha commented Oct 8, 2015

As I mentioned here is an issue #7 that blocks following guide, I'll try rake build and if it succeed we have 2 options. Update guide or update package.json file.

@G07cha
Copy link
Contributor Author

G07cha commented Oct 8, 2015

Find the way to run app, it requires tsd module installed globally and as you said compiled TypeScript. Should we add preinstall hook to package.json?

@rhysd
Copy link
Owner

rhysd commented Oct 8, 2015

OK, I'll write instruction to README. Could you check it?

@G07cha
Copy link
Contributor Author

G07cha commented Oct 8, 2015

Sure, I also can update this pr with correct instruction.

@rhysd
Copy link
Owner

rhysd commented Oct 8, 2015

I wrote.

https://github.com/rhysd/Trendy#development

Could you try this?

@G07cha
Copy link
Contributor Author

G07cha commented Oct 8, 2015

Yep, It's correct.

@G07cha G07cha closed this Oct 8, 2015
@rhysd
Copy link
Owner

rhysd commented Oct 8, 2015

Thank you for the confirmation. It was helpful.

@G07cha G07cha deleted the patch-1 branch October 8, 2015 09:15
@G07cha
Copy link
Contributor Author

G07cha commented Oct 8, 2015

You are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants