Skip to content
This repository was archived by the owner on Oct 25, 2023. It is now read-only.

Conversation

schnubor
Copy link

@schnubor schnubor commented Aug 5, 2014

Providing string params for 'artist', 'title' and 'format' in search gave me errors so I noticed the majority of params were actually declared as booleans. I guess that shouldn't be the case. According to Discogs every param should be a string:

http://www.discogs.com/developers/#page:database,header:database-search

tested 'artist', 'title' and 'format' as string again and it worked. Didn't doublecheck the other params though.

@ricbra
Copy link
Owner

ricbra commented Aug 6, 2014

I made a mistake there. The've updated the API docs pages lately, now all params are better documented. I thought these were booleans to trigger the search of q.

Thanks for your PR, could you also fix the search test?

@schnubor
Copy link
Author

schnubor commented Aug 6, 2014

Yep, the new docs are much better now. Fixed the test, sorry :)

ricbra added a commit that referenced this pull request Aug 6, 2014
replaced boolean search params with string according to discogs docs
@ricbra ricbra merged commit 01a359b into ricbra:master Aug 6, 2014
@ricbra
Copy link
Owner

ricbra commented Aug 6, 2014

Thanks @schnubor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants