Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module context switching in AccessInterface #44

Closed
wants to merge 1 commit into from

Conversation

hagau
Copy link
Contributor

@hagau hagau commented Nov 13, 2018

Fix macro expansion in AccessInterface, see definition of Enter_Method in omnetpp/simutil.h

Fixes:

ASSERT: Condition 'currentMethodCall' does not hold in function 'methodcallEnd' at messageanimator.cc:128
-- in module (artery::Router) World.node[0].vanetza[0].router (id=144), at t=0.259284461639s, event #6

@riebl
Copy link
Owner

riebl commented Nov 14, 2018

Merged as 2f2a01a, thanks!
I am still confused why there has been no problem on my system w.r.t. "currentMethodCall"...

@riebl riebl closed this Nov 14, 2018
@hagau
Copy link
Contributor Author

hagau commented Nov 14, 2018

@riebl This only happens when running with the GUI, at least with Qtenv.

@hagau hagau deleted the fix_context_switch branch November 14, 2018 11:44
@hagau
Copy link
Contributor Author

hagau commented Nov 15, 2018

Btw, while re-checking the fix for this, I noticed vanetza::geonet::Router::pass_down calling directly into vanetza::dcc::FlowControl::request. Shouldn't there be a RequestInterface shim to switch context from artery::Router to artery::FsmDccEntity at that interface?

@riebl
Copy link
Owner

riebl commented Nov 15, 2018

Would this have any benefit? Router and DCC just became OMNeT++ modules to ease exchange of DCC implementations, i.e. there is no traditional OMNeT++ message passing intended between those modules.

@hagau
Copy link
Contributor Author

hagau commented Nov 15, 2018

True, I was just suprised when I saw that while investigating this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants