gather some simple metrics on query and fetch time #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| es_search_index = options[:es_search_index] | ||
| path_prefix = options[:path_prefix] | ||
| path_prefix[0] = '' if path_prefix[0]=='/' | ||
| path_prefix[path_prefix.length-1] = '' if path_prefix[path_prefix.length-1]=='/' |
There was a problem hiding this comment.
This is essentially duplicate code - perhaps pull out into a method and call it in all the *_url methods?
|
@jamtur01 any chance we can get this done soon? |
|
I'll try to look at it later tonight. |
| def response_is_bad(response) | ||
| return true if response.nil? | ||
|
|
||
| is_bad = response.status != 200 |
There was a problem hiding this comment.
The logic here could be simplified.
if response.status != 200
. . .
|
@jamtur01 any additional comments on how to make it better? |
|
I'll try another look later today. |
|
Thanks! |
jamtur01
added a commit
that referenced
this pull request
Feb 18, 2016
gather some simple metrics on query and fetch time
|
Thanks as well. Are you able to tag another version in the next days? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I'd like to have some more insight into Elasticsearch during operations I added two metrics.