Update FreeBSD load average for 1 min #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the load array retrieval method by parsing the output of the 'uptime' command and creating an array of load average values.
|
I'm still not sure why we need to divide by the number of cores, but I didn't touch it since its elsewhere in the code as well. Can someone enlighten me on why this is? Doesn't the uptime command already compute load based on cores? |
|
Load, at least on linux systems, is the number of processes on the run queue, so a load of 24 on a 48-core box is (kinda) as contended as a load of 0.5 on a single-core machine. |
aphyr
added a commit
that referenced
this pull request
Mar 26, 2014
Update FreeBSD load average for 1 min
|
Thanks for the fix! |
|
Would you mind cutting a new gem for this change please? I'm just in the initial phase of getting started with the system. I'd appreciate it. |
|
No problem; 0.2.1 cut and pushed. :) |
|
Excellent, thank you. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the load array retrieval method by parsing the output of
the 'uptime' command and creating an array of load average values.