Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better types for typescript #160

Merged
merged 2 commits into from Sep 17, 2019

Conversation

@ChristianStornowski
Copy link
Contributor

commented Sep 17, 2019

Added possibility to use:

import VueScrollTo from "vue-scrollto";

VueScrollTo.scrollTo(element.$el, {offset: -125, duration: 1});
@rigor789

This comment has been minimized.

Copy link
Owner

commented Sep 17, 2019

Hey @ChristianStornowski thanks for the PR!

I'm not a TS user (yet), but I wonder if these type definitions will account for the returned cancel function from this.$scrollTo and VueScrollTo.scrollTo?

@ChristianStornowski

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2019

Sorry. I missed this cancel function. :-/
I added this function

@rigor789 rigor789 merged commit f6a6596 into rigor789:master Sep 17, 2019
2 of 5 checks passed
2 of 5 checks passed
Header rules No header rules processed
Details
Pages changed 6 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
@rigor789

This comment has been minimized.

Copy link
Owner

commented Sep 17, 2019

🎉 This PR is included in version 2.17.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rigor789 rigor789 added the released label Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.