Simplify the API to @precompile_module(M)
#5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
@precompile_module(Foo)
.include(precompile_directives(M))
turns out to be wrong. Developers wouldn't push this, so the risk doesn't lie there. However, this package could make a mistake in generating precompile directives causing breaking downstream packages? Would be better to show warnings in that case and still allow the package to be used.precompile
call in a function with a try-catch.Benchmark
On Julia 1.7.3 with Pluto
Before this PR (via
include(precompile_directives(Pluto))
)Precompiled in 17 seconds
After this PR (via
@precompile_module(Pluto)
)Precompiled in 17 seconds