-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unwanted characters are inserted when escaping CSS strings #121
Comments
Ok that's a weird issue, it seems that the preprocessor adds chars to escape to the css code. I will check this issue during the weekend thank you for reporting it! |
I am trying to reproduce the issue but I got no luck. Could you please post the css string failing? |
* master: fixed: eslint warning 4.3.6 updated: changelog closes #122 closes #122 added: test for #121 added: other tests fix: Chained object access as text expression fixes riot/riot#2737 4.3.5 updated: fix css unicode properties 4.3.4 updated: changelog updated: attempt to fix riot/riot#2714 4.3.3 added: changelog
Ok locally I was unable to produce the issue but the CI seems to have found it https://travis-ci.org/riot/compiler |
@nibushibu ok the issue appears only in node 10. Everything works fine in node 12. I am trying to find a solution |
I hope you can check my repository below.
https://github.com/nibushibu/Getup
After compilation, unnecessary characters are inserted into CSS (SCSS) described in the file
/ src/riot/my-app.riot
.Before
After (compiled)
When I checked why the unwanted
A
character was inserted, I found that it was inserted aftercssEscape ()
was executed.compiler/src/generators/css/index.js
Lines 105 to 108 in 227c544
cssEscape (preprocessorOutput.code)
By rewriting the above part (2 places) as below, we could avoid the problem for the time being.
preprocessorOutput.code
I think the above is temporary workaround, but I could not find a fundamental solution.
If this is a problem with my file, please point out the cause, or if it is a bug, please help me solve it. 🙇
The text was updated successfully, but these errors were encountered: