fixes https://github.com/riot/riot/issues/2726 #118
Conversation
- visitMemberExpression only replaces path scope if the identifier for the expression doesn't exist in scope
| * @param {Scope} scope - scope where to search for the identifier | ||
| * @returns {boolean} true if the node identifier is defined in the given scope | ||
| */ | ||
| function nodeIdentifierExistsInScope(node, scope) { |
There was a problem hiding this comment.
I think this function could be part of the isGlobal function. Could you please try to use it there?
| * @returns {boolean} true if the node identifier is defined in the given scope | ||
| */ | ||
| function nodeIdentifierExistsInScope(node, scope) { | ||
| let found = false // eslint-disable-line |
There was a problem hiding this comment.
is there a way to use this function in a more functional way avoiding the let statement? Probably we can use the return value of types.visit. Let's use mutable variables only if they are only the last resort
There was a problem hiding this comment.
Ok, I have tried it, both with the return type and by trying to catch the exception, but the return type is the starting node used in the traversal, and the exception isn't propagated.
But I will see what I can do with both of your suggestions, I will only be able to work on it after next Wednesday.
But I give you some feedback then.
Cheers
|
@hudelgado thank you I will have update your patch refactoring a bit your solution. Your help has been really appreciated |
|
@GianlucaGuarini, i'm glad my help was valuable. |
It fixes the visitMemberExpression by only prefixing the identifier for the expression if it doesn't exist in scope.
It does that by traversing a
MemberExpressionlooking for the left mostIdentifierand looking up for it's name in the given scope.I'm not sure if this was exactly what you had in mind, but i'm okay with improving it accordingly to your suggestions.
Cheers