This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Expanded includes #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user can add a new key to the dash.yaml like:: :graph_properties: :environment: dev :server: [ a_server_name ] :javaid: 1234 that can be accessed from the .graph like: server = @properties[:server] environment = @properties[:environment] field :iowait, :alias => "IO Wait #{server}", :data => "servers.#{server}.cpu*.cpu-{system,wait}.value"
The user can specify a list of dashboards to include: :include: - "templates/os.basic" - "templates/os.nfs" It will also ignore "categories" that have no dashboard, so you can create a "templates" category with different templates.
1) Add ability to include YAML files that are treated as dash.yaml mixins. If you have a long server list with defined colors that you woud like to appear across several dashboards, for instance, you can define that list in one place and mix it in to several dashboard YAML files. 2) Rename the existing functionality for including graph templates from "include" to "include_graphs," to make it distinct from include_properties.
|
Would love to see this merged, it is really useful. |
|
Looking quite unlikely I'll get this merged in its current state as code paths have diverged too much and there are big conflicts I do not have time to resolve :( |
|
Actually in my branch I just merged ripienaar's last commits. All this code is merged there. |
|
The same goes for my branch (test). But I think merging back into the master would be a good thing regarding further development. Otherwise the diverge will get worse. |
|
I'll take a look - the one in this PR def does not merge cleanly for me on master |
|
@moxie0 do you want to merge this? |
Closed
|
This should be in master with #66 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some more include functionality on top of what @keymon provided (which I found extremely useful).