Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox for block images #68

Closed
eric-schneider opened this issue Jan 17, 2024 · 3 comments · Fixed by #106
Closed

Lightbox for block images #68

eric-schneider opened this issue Jan 17, 2024 · 3 comments · Fixed by #106
Labels
enhancement New feature or request

Comments

@eric-schneider
Copy link
Contributor

eric-schneider commented Jan 17, 2024

By default, images are constrained by the width of the article body. Users should have the ability to enlarge an image if they so choose. Our old UI has rudimentary lightbox library that allows the user to click an image to open a larger version in a lightbox. We should consider adding a similar feature to the new UI.

My preference would be to work with the Antora community on implementing Issue-140 (MR-126). Based on the conversation in the aforementioned merge request, it seems that there are still a few additional enhancements that need to be made.

NOTE: This enhancement is currently a dependency of #73. The lightbox library we choose should probably be used to power the interactive graphic in addition to the other images on the site.

@eric-schneider eric-schneider added the enhancement New feature or request label Jan 17, 2024
@johnsmartco
Copy link
Contributor

Thanks @eric-schneider for highlighting the existing functionality from the prior ui in this new docs-ui issue.

Example on:

https://docs.datastax.com/en/astra-serverless/docs/migrate/migrate-and-validate-data.html

Click the "squished" graphic ... opens a 100% view ... click again, returns user to the topic.

@colegoldsmith colegoldsmith linked a pull request Mar 6, 2024 that will close this issue
@eric-schneider
Copy link
Contributor Author

@colegoldsmith I'm re-opening this issue because I think we overlooked a couple things.

  1. The lightbox doesn't appear to work for images that use the svg:: macro.
    a. Note: If/when we enable this, we need to make sure that it's not enabled on images like the ones on the landing page:
    image

  2. We should probably add a background that's the same size as the image, otherwise images with transparent backgrounds look funky overlaid on top of the page content.
    image

@eric-schneider
Copy link
Contributor Author

Decided to create a new issue to capture these enhancements/fixes. See #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants