Skip to content

Docs core pages spacing and typography updates #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 3, 2024
Merged

Docs core pages spacing and typography updates #118

merged 9 commits into from
Apr 3, 2024

Conversation

kurtenj
Copy link
Collaborator

@kurtenj kurtenj commented Apr 2, 2024

Figma: https://www.figma.com/file/CdccUCtTuxCBD32uOF3T5w/%5BEXPL%5D-Docs-Core-Uplift?type=design&node-id=242-829&mode=design

  • Cut the global padding between elements to 12px (down from 24px, condensed page height overall)
  • Add a 32px margin-top to h3 and h4 (groups titled content better)
  • Increase the size of h3 to 18px (up from 16px) and face to Sora (from Roboto)
  • Increase the size of h4 to 16px (up from 15px)
  • Change all paragraph text color to text-secondary (from text-primary)

image

@kurtenj
Global padding to 12px, 32px margin-top to h3 and h4, h3 to 18px and …
065e5ce 
…face to Sora, h4 to 16px, all paragraph text color to text-secondary
@kurtenj kurtenj linked an issue Apr 2, 2024 that may be closed by this pull request
Review and update section/block title styles #116
Closed
@mlr
Copy link
Contributor

mlr commented Apr 2, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Apr 2, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.

@kurtenj kurtenj requested a review from mlr April 2, 2024 15:31
@kurtenj kurtenj changed the title Global padding to 12px, 32px margin-top to h3 and h4, h3 to 18px and … Docs core pages spacing and typography updates Apr 2, 2024
@mlr
Copy link
Contributor

mlr commented Apr 2, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Apr 2, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 2, 2024

changes look good!

@mlr
Copy link
Contributor

mlr commented Apr 2, 2024

UI bundle preview build failure! ❌

[23:59:01] Using gulpfile ~/work/docs-ui/docs-ui/gulpfile.js [23:59:01] Starting 'preview:build'... [23:59:01] Starting 'build'... [23:59:01] Starting 'preview:build-pages'... [23:59:03] Finished 'preview:build-pages' after 1.6 s [23:59:03] 'build' errored after 2.37 s [23:59:03] �[31mCssSyntaxError�[39m in plugin "�[36mgulp-postcss�[39m" Message: postcss-import: /home/runner/work/docs-ui/docs-ui/src/css/asciidoc/doc.css:73:15: Missed semicolon �[90m 71 | �[39m �[90m 72 | �[39m �[33m.doc�[39m h4�[33m:�[39m�[36mnot�[39m�[36m(.discrete)�[39m �[33m{�[39m �[1m�[31m>�[39m�[22m�[90m 73 | �[39m color�[33m:�[39m �[36mvar�[39m�[36m(--ds-tertiary)�[39m �[90m | �[39m �[1m�[31m^�[39m�[22m �[90m 74 | �[39m font-weight�[33m:�[39m 600�[33m;�[39m �[90m 75 | �[39m �[33m}�[39m [23:59:03] 'preview:build' errored after 2.37 s

@mlr
Copy link
Contributor

mlr commented Apr 2, 2024

Antora site build failure! ❌

[23:59:33] Using gulpfile ~/work/datastax-docs-site/datastax-docs-site/ui-bundle-preview/gulpfile.js [23:59:33] Starting 'bundle'... [23:59:33] Starting 'clean'... [23:59:33] Finished 'clean' after 13 ms [23:59:33] Starting 'lint'... [23:59:34] Finished 'lint' after 1.29 s [23:59:34] Starting 'build'... [23:59:37] gulp-imagemin: Minified 8 images (saved 72.4 kB - 49.3%) [23:59:38] 'build' errored after 3.58 s [23:59:38] �[31mCssSyntaxError�[39m in plugin "�[36mgulp-postcss�[39m" Message: postcss-import: /home/runner/work/datastax-docs-site/datastax-docs-site/ui-bundle-preview/src/css/asciidoc/doc.css:73:15: Missed semicolon �[90m 71 | �[39m �[90m 72 | �[39m �[33m.doc�[39m h4�[33m:�[39m�[36mnot�[39m�[36m(.discrete)�[39m �[33m{�[39m �[1m�[31m>�[39m�[22m�[90m 73 | �[39m color�[33m:�[39m �[36mvar�[39m�[36m(--ds-tertiary)�[39m �[90m | �[39m �[1m�[31m^�[39m�[22m �[90m 74 | �[39m font-weight�[33m:�[39m 600�[33m;�[39m �[90m 75 | �[39m �[33m}�[39m [23:59:38] 'bundle' errored after 4.89 s

@kurtenj kurtenj requested a review from mlr April 3, 2024 00:05
@mlr
Copy link
Contributor

mlr commented Apr 3, 2024

UI bundle preview build failure! ❌

[00:07:39] Using gulpfile ~/work/docs-ui/docs-ui/gulpfile.js [00:07:39] Starting 'preview:build'... [00:07:39] Starting 'build'... [00:07:39] Starting 'preview:build-pages'... [00:07:41] Finished 'preview:build-pages' after 1.5 s [00:07:41] 'build' errored after 2.28 s [00:07:41] �[31mCssSyntaxError�[39m in plugin "�[36mgulp-postcss�[39m" Message: postcss-import: /home/runner/work/docs-ui/docs-ui/src/css/asciidoc/doc.css:73:15: Missed semicolon �[90m 71 | �[39m �[90m 72 | �[39m �[33m.doc�[39m h4�[33m:�[39m�[36mnot�[39m�[36m(.discrete)�[39m �[33m{�[39m �[1m�[31m>�[39m�[22m�[90m 73 | �[39m color�[33m:�[39m �[36mvar�[39m�[36m(--ds-text-tertiary)�[39m �[90m | �[39m �[1m�[31m^�[39m�[22m �[90m 74 | �[39m font-weight�[33m:�[39m 600�[33m;�[39m �[90m 75 | �[39m �[33m}�[39m [00:07:41] 'preview:build' errored after 2.28 s

@mlr
Copy link
Contributor

mlr commented Apr 3, 2024

Antora site build failure! ❌

[00:08:25] Using gulpfile ~/work/datastax-docs-site/datastax-docs-site/ui-bundle-preview/gulpfile.js [00:08:25] Starting 'bundle'... [00:08:25] Starting 'clean'... [00:08:25] Finished 'clean' after 13 ms [00:08:25] Starting 'lint'... [00:08:26] Finished 'lint' after 1.25 s [00:08:26] Starting 'build'... [00:08:29] gulp-imagemin: Minified 8 images (saved 72.4 kB - 49.3%) [00:08:29] 'build' errored after 3.55 s [00:08:29] �[31mCssSyntaxError�[39m in plugin "�[36mgulp-postcss�[39m" Message: postcss-import: /home/runner/work/datastax-docs-site/datastax-docs-site/ui-bundle-preview/src/css/asciidoc/doc.css:73:15: Missed semicolon �[90m 71 | �[39m �[90m 72 | �[39m �[33m.doc�[39m h4�[33m:�[39m�[36mnot�[39m�[36m(.discrete)�[39m �[33m{�[39m �[1m�[31m>�[39m�[22m�[90m 73 | �[39m color�[33m:�[39m �[36mvar�[39m�[36m(--ds-text-tertiary)�[39m �[90m | �[39m �[1m�[31m^�[39m�[22m �[90m 74 | �[39m font-weight�[33m:�[39m 600�[33m;�[39m �[90m 75 | �[39m �[33m}�[39m [00:08:29] 'bundle' errored after 4.82 s

@mlr
Copy link
Contributor

mlr commented Apr 3, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Apr 3, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 3, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Apr 3, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 3, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Apr 3, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 3, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Apr 3, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 3, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Apr 3, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@kurtenj kurtenj merged commit 54d771c into main Apr 3, 2024
@kurtenj kurtenj deleted the 116-review-and-update-sectionblock-title-styles branch April 3, 2024 16:57
@kurtenj kurtenj self-assigned this Apr 3, 2024
@eric-schneider eric-schneider mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlr mlr mlr approved these changes

Assignees

@kurtenj kurtenj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review and update section/block title styles
3 participants
@kurtenj @mlr @eric-schneider