Use variables instead of explicit URLs #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-schneider
changed the title
|
UI bundle preview build successful! ✅ |
|
Antora site build successful! ✅ |
mlr
approved these changes
May 1, 2024
|
@eric-schneider Apologies for the late reply here. The double vs triple moustache is that double is html escaped, triple is not https://handlebarsjs.com/guide/expressions.html#html-escaping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started out as @mlr and I's attempt to fix the homepage link on the 404 page. I then noticed a few URLs that could probably be made more durable using variables.
@colegoldsmith, Ronnie and I are pretty unfamiliar with variables and handlebars, but after a little testing we think these are working as expected. I'm also pretty unfamiliar with the proper use of double and triple mustaches, and I don't know how all of these meta properties are supposed to work. Can you pick up where we left off?