Global Nav #124

colegoldsmith · 2024-04-26T19:35:51Z

Main updates:

When `site.keys.global_nav` is present the new nav will be displayed

New version switcher placed in the side nav

Removed the old broken version switcher in the ToC

Tested this new UI bundle without `site.keys.global_nav` with the existing playbook and the site is styled properly

mlr · 2024-04-26T19:36:28Z

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

mlr · 2024-04-26T19:37:03Z

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

mlr · 2024-04-26T19:37:19Z

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

mlr · 2024-04-26T19:37:59Z

Antora site build successful! ✅
Deploying draft to GitHub Pages.

mlr · 2024-04-26T20:59:53Z

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

mlr · 2024-04-26T21:00:46Z

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

mlr · 2024-04-26T21:00:49Z

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

mlr · 2024-04-26T21:06:19Z

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

mlr · 2024-04-26T21:07:09Z

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

mlr · 2024-04-26T21:07:13Z

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

…-nav

mlr · 2024-04-29T19:06:33Z

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

mlr · 2024-04-29T19:07:25Z

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

mlr · 2024-04-29T19:07:26Z

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

mlr · 2024-04-29T19:17:23Z

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

mlr · 2024-04-29T19:18:12Z

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

mlr · 2024-04-29T19:18:13Z

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

mlr · 2024-04-29T19:29:40Z

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

mlr · 2024-04-29T19:30:33Z

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

mlr · 2024-04-29T19:30:42Z

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

mlr · 2024-04-29T20:51:41Z

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

mlr · 2024-05-01T21:28:33Z

Antora site build successful! ✅
Deploying draft to GitHub Pages.

mlr · 2024-05-01T21:28:33Z

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft
Deployment successful! View draft

mlr · 2024-05-02T04:53:03Z

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

mlr · 2024-05-02T04:54:00Z

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

mlr · 2024-05-02T04:54:05Z

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

mlr · 2024-05-02T20:22:18Z

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

mlr · 2024-05-02T20:23:20Z

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

mlr · 2024-05-02T20:30:34Z

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

mlr · 2024-05-02T20:31:22Z

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

mlr

Tested locally with a release build that includes DSE so I could try the version switcher. It's working great.

@eric-schneider We'll probably want to adjust the global nav values on the playbook side, or at least have you take a look at them when we bump the playbook to the version that includes these changes.

kurtenj · 2024-05-02T23:44:18Z

Looking slick, @colegoldsmith! Just a few fixes:

Can we slow down the speed at which the nav dropdown appears/disappears as well as the rotation of the chevron?
Let's keep the version switcher an on-click action instead of opening the list on hover
The home nav item is missing the icon and border-right

I think we should also drop the background on hover for the nav items
Let's look at simplifying the active style, perhaps just a straight primary-main on the text

mlr · 2024-05-03T20:16:29Z

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

mlr · 2024-05-03T20:17:31Z

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

colegoldsmith · 2024-05-03T20:19:26Z

Thanks @kurtenj! I just pushed an update that should address all your comments.

colegoldsmith · 2024-05-03T20:21:42Z

@mlr @eric-schneider To get the special "Docs Home" styling I made it conditional on the site.keys.global_nav item having a special flag. For the home link you'll want to add home: true like this

{ 
  "title": "Docs Home",
  "xref": "home::index.adoc",
  "home": true
},

mlr · 2024-05-03T20:26:21Z

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

mlr · 2024-05-03T20:27:09Z

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

mlr · 2024-05-03T20:37:08Z

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

mlr · 2024-05-03T20:38:03Z

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

colegoldsmith added 3 commits April 26, 2024 14:26

new global nav

e099b50

remove package

d37dcd0

Merge branch 'main' of github.com:riptano/docs-ui into unified-nav

0ad6432

Add unified draft trigger workflow

7d6f8aa

Add branch to unified draft trigger push arguments

69839fb

colegoldsmith added 2 commits April 29, 2024 14:05

scrolling nav buttons

1c9da2f

Merge branch 'unified-nav' of github.com:riptano/docs-ui into unified…

dfe08c5

…-nav

highlight active menu item

9167bc7

shift dropdown middleware

84df49e

conditionally render global nav styles

f8626ea

page version changes

8c54b4e

colegoldsmith requested review from kurtenj, eric-schneider and mlr May 2, 2024 19:38

Merge branch 'main' into unified-nav

01f9925

Undo unintentional changes to draft workflow

07c6e9f

mlr approved these changes May 2, 2024

View reviewed changes

design review changes

5a2f5d2

icon color change

a872f89

global nav change

2da0f5c

mlr merged commit b466aa7 into main May 3, 2024
2 checks passed

mlr deleted the unified-nav branch May 3, 2024 20:45

Global Nav #124

Global Nav #124

Conversation

colegoldsmith commented Apr 26, 2024 • edited Loading

When site.keys.global_nav is present the new nav will be displayed

New version switcher placed in the side nav

Removed the old broken version switcher in the ToC

Tested this new UI bundle without site.keys.global_nav with the existing playbook and the site is styled properly

mlr commented Apr 26, 2024 • edited Loading

mlr commented Apr 26, 2024 • edited Loading

mlr commented Apr 26, 2024 • edited Loading

mlr commented Apr 26, 2024

mlr commented Apr 26, 2024 • edited Loading

mlr commented Apr 26, 2024 • edited Loading

mlr commented Apr 26, 2024 • edited Loading

mlr commented Apr 26, 2024 • edited Loading

mlr commented Apr 26, 2024 • edited Loading

mlr commented Apr 26, 2024 • edited Loading

mlr commented Apr 29, 2024 • edited Loading

mlr commented Apr 29, 2024 • edited Loading

mlr commented Apr 29, 2024 • edited Loading

mlr commented Apr 29, 2024 • edited Loading

mlr commented Apr 29, 2024 • edited Loading

mlr commented Apr 29, 2024 • edited Loading

mlr commented Apr 29, 2024 • edited Loading

mlr commented Apr 29, 2024 • edited Loading

mlr commented Apr 29, 2024 • edited Loading

mlr commented Apr 29, 2024 • edited Loading

mlr commented May 1, 2024

mlr commented May 1, 2024 • edited Loading

mlr commented May 2, 2024 • edited Loading

mlr commented May 2, 2024 • edited Loading

mlr commented May 2, 2024 • edited Loading

mlr commented May 2, 2024 • edited Loading

mlr commented May 2, 2024 • edited Loading

mlr commented May 2, 2024 • edited Loading

mlr commented May 2, 2024 • edited Loading

mlr left a comment

Choose a reason for hiding this comment

kurtenj commented May 2, 2024 • edited Loading

mlr commented May 3, 2024 • edited Loading

mlr commented May 3, 2024 • edited Loading

colegoldsmith commented May 3, 2024

colegoldsmith commented May 3, 2024

mlr commented May 3, 2024 • edited Loading

mlr commented May 3, 2024 • edited Loading

mlr commented May 3, 2024 • edited Loading

mlr commented May 3, 2024 • edited Loading

colegoldsmith commented Apr 26, 2024 •

edited

Loading

When `site.keys.global_nav` is present the new nav will be displayed

Tested this new UI bundle without `site.keys.global_nav` with the existing playbook and the site is styled properly

mlr commented Apr 26, 2024 •

edited

Loading

mlr commented Apr 26, 2024 •

edited

Loading

mlr commented Apr 26, 2024 •

edited

Loading

mlr commented Apr 26, 2024 •

edited

Loading

mlr commented Apr 26, 2024 •

edited

Loading

mlr commented Apr 26, 2024 •

edited

Loading

mlr commented Apr 26, 2024 •

edited

Loading

mlr commented Apr 26, 2024 •

edited

Loading

mlr commented Apr 26, 2024 •

edited

Loading

mlr commented Apr 29, 2024 •

edited

Loading

mlr commented Apr 29, 2024 •

edited

Loading

mlr commented Apr 29, 2024 •

edited

Loading

mlr commented Apr 29, 2024 •

edited

Loading

mlr commented Apr 29, 2024 •

edited

Loading

mlr commented Apr 29, 2024 •

edited

Loading

mlr commented Apr 29, 2024 •

edited

Loading

mlr commented Apr 29, 2024 •

edited

Loading

mlr commented Apr 29, 2024 •

edited

Loading

mlr commented Apr 29, 2024 •

edited

Loading

mlr commented May 1, 2024 •

edited

Loading

mlr commented May 2, 2024 •

edited

Loading

mlr commented May 2, 2024 •

edited

Loading

mlr commented May 2, 2024 •

edited

Loading

mlr commented May 2, 2024 •

edited

Loading

mlr commented May 2, 2024 •

edited

Loading

mlr commented May 2, 2024 •

edited

Loading

mlr commented May 2, 2024 •

edited

Loading

kurtenj commented May 2, 2024 •

edited

Loading

mlr commented May 3, 2024 •

edited

Loading

mlr commented May 3, 2024 •

edited

Loading

mlr commented May 3, 2024 •

edited

Loading

mlr commented May 3, 2024 •

edited

Loading

mlr commented May 3, 2024 •

edited

Loading

mlr commented May 3, 2024 •

edited

Loading