Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Nav #124

Merged
merged 18 commits into from
May 3, 2024
Merged

Global Nav #124

merged 18 commits into from
May 3, 2024

Conversation

colegoldsmith
Copy link
Collaborator

@colegoldsmith colegoldsmith commented Apr 26, 2024

Main updates:

When site.keys.global_nav is present the new nav will be displayed

Screenshot 2024-05-02 at 2 25 49 PM

New version switcher placed in the side nav

Screenshot 2024-05-02 at 2 25 06 PM

Removed the old broken version switcher in the ToC

Screenshot 2024-05-02 at 2 35 57 PM

Tested this new UI bundle without site.keys.global_nav with the existing playbook and the site is styled properly

Screenshot 2024-05-02 at 2 45 37 PM

@mlr
Copy link
Contributor

mlr commented Apr 26, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

1 similar comment
@mlr
Copy link
Contributor

mlr commented Apr 26, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Apr 26, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 26, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.

@mlr
Copy link
Contributor

mlr commented Apr 26, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Apr 26, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 26, 2024

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 26, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Apr 26, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 26, 2024

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 29, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Apr 29, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 29, 2024

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 29, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Apr 29, 2024

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 29, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 29, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Apr 29, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 29, 2024

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Apr 29, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 1, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.

@mlr
Copy link
Contributor

mlr commented May 1, 2024

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented May 2, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 2, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented May 2, 2024

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented May 2, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 2, 2024

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented May 2, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 2, 2024

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

Copy link
Contributor

@mlr mlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with a release build that includes DSE so I could try the version switcher. It's working great.

@eric-schneider We'll probably want to adjust the global nav values on the playbook side, or at least have you take a look at them when we bump the playbook to the version that includes these changes.

@kurtenj
Copy link
Collaborator

kurtenj commented May 2, 2024

Looking slick, @colegoldsmith! Just a few fixes:

  • Can we slow down the speed at which the nav dropdown appears/disappears as well as the rotation of the chevron?
  • Let's keep the version switcher an on-click action instead of opening the list on hover
  • The home nav item is missing the icon and border-right
image
  • I think we should also drop the background on hover for the nav items
  • Let's look at simplifying the active style, perhaps just a straight primary-main on the text

image

@mlr
Copy link
Contributor

mlr commented May 3, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 3, 2024

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@colegoldsmith
Copy link
Collaborator Author

Thanks @kurtenj! I just pushed an update that should address all your comments.

@colegoldsmith
Copy link
Collaborator Author

@mlr @eric-schneider To get the special "Docs Home" styling I made it conditional on the site.keys.global_nav item having a special flag. For the home link you'll want to add home: true like this

{ 
  "title": "Docs Home",
  "xref": "home::index.adoc",
  "home": true
},

@mlr
Copy link
Contributor

mlr commented May 3, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 3, 2024

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented May 3, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 3, 2024

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr mlr merged commit b466aa7 into main May 3, 2024
2 checks passed
@mlr mlr deleted the unified-nav branch May 3, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants