-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global Nav #124
Global Nav #124
Conversation
UI bundle preview build successful! ✅ |
1 similar comment
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
Antora site build successful! ✅ |
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
Antora site build successful! ✅ |
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
Antora site build successful! ✅ |
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
Antora site build successful! ✅ |
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
Antora site build successful! ✅ |
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
Antora site build successful! ✅ |
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
Antora site build successful! ✅ |
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
Antora site build successful! ✅ |
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally with a release build that includes DSE so I could try the version switcher. It's working great.
@eric-schneider We'll probably want to adjust the global nav values on the playbook side, or at least have you take a look at them when we bump the playbook to the version that includes these changes.
Looking slick, @colegoldsmith! Just a few fixes:
|
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
Thanks @kurtenj! I just pushed an update that should address all your comments. |
@mlr @eric-schneider To get the special "Docs Home" styling I made it conditional on the site.keys.global_nav item having a special flag. For the home link you'll want to add
|
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
UI bundle preview build successful! ✅ |
Antora site build successful! ✅ |
Main updates:
When
site.keys.global_nav
is present the new nav will be displayedNew version switcher placed in the side nav
Removed the old broken version switcher in the ToC
Tested this new UI bundle without
site.keys.global_nav
with the existing playbook and the site is styled properly