Modify svg helper so it references path correctly in preview and build #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the svg handlerbars helper so the svg is rendered with an
img
tag rather than attempting to read the content of the svg file and return that to the rendered page.The reason this is necessary is because at build time, the path to the UI bundle isn't the same as when running a UI preview build. By using an image tag we can simply refer to the
uiRootPath
so the image knows where to look when the page is compiled to its static HTMLTo test:
gulp bundle
npm run build:develop
for the datastax docs site