Small Style Updates #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colegoldsmith Have you looked into updating the size of the DocSearch modal? See https://datastax.slack.com/archives/C05Q75MQ6UC/p1696638343141439?thread_ts=1696575191.091319&cid=C05Q75MQ6UC |
|
@eric-schneider Yep I changed the width of the modal in the previous PR I made! It now matches the width of the command palette in Astra, 720px |
colegoldsmith
commented
Oct 13, 2023
|
|
||
| @media screen and (max-width: 1023.5px) { | ||
| :root { | ||
| --navbar-height: calc(74 / var(--rem-base) * 1rem); |
There was a problem hiding this comment.
Making the top nav height smaller on mobile widths gives more screen real estate for content. Especially helpful on phone screens
There was a problem hiding this comment.
We could probably improve this more by refactoring how the left nav is opened on mobile. The button for that currently takes up a whole row being in the "toolbar" element
mlr
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of little styling issues I noticed. I'll try to list all that was fixed: