Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography #5

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Typography #5

merged 4 commits into from
Sep 14, 2023

Conversation

josuebran
Copy link
Contributor

@josuebran josuebran commented Sep 14, 2023

Typography

  • Updates color, font weight and line height of docs, breadcrumbs and toc menu
  • Updates font size with css calc method used in antora. Please let me know if we should use another method.

Formatting Headers and titles

  • Updates padding and margin for headers and title
  • Updates padding and margin for body, article, toc sidebar and breadcrumb

Demo: https://docs-ui-typography.netlify.app/docs/

--toolbar-font-color: var(--ds-text-primary);
--toolbar-muted-color: var(--ds-text-disabled);
--toolbar-font-color: var(--ds-primary-main);
--toolbar-muted-color: var(--ds-text-tertiary);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change using the tokens! Lol I'm not sure why I set that to the disabled color

Copy link
Collaborator

@colegoldsmith colegoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work

@colegoldsmith
Copy link
Collaborator

@josuebran Do you think adding postcss-mixins would give us some good utility for work like this? Something like

@define-mixin h1 {
  font-size: calc(24 / var(--rem-base) * 1rem)
  font-weight: 500
}

Then to implement in a selector

.class-name {
  @mixin h1;
}

@josuebran
Copy link
Contributor Author

@colegoldsmith Yes, postcss-mixins would be helpful

@colegoldsmith
Copy link
Collaborator

@josuebran Do you want to add postcss mixins to the gulp build and make the change in this PR? Otherwise you can just merge this and refactor once we get the plugin added later

@josuebran josuebran merged commit 857d319 into main Sep 14, 2023
@josuebran josuebran deleted the typography branch October 4, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants