Skip to content

Conversation

jtgrabowski
Copy link

No description provided.

@jtgrabowski jtgrabowski force-pushed the DSP-13836 branch 2 times, most recently from f075aa6 to a2111be Compare July 11, 2017 13:51
withouth this change, tar file contained directory "." with desired
content. Now content is placed at the root of the archive.
lazy val mesos = sys.env.getOrElse("MESOS_VERSION", "1.0.0-2.0.89.ubuntu1404")
lazy val metrics = "2.2.0"
lazy val netty = "4.0.42.Final"
lazy val netty = "4.0.44.Final"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.1 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DSP-14152

Copy link

@jacek-lewandowski jacek-lewandowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment - we probably need to bump Netty to 4.1 since we do it for Spark. This may follow bumping Akka to some newer release which works with Netty 4.1.

val excludeScalaTest = ExclusionRule(organization = "org.scalatest")
val excludeScala = ExclusionRule(organization = "org.scala-lang")
val excludeNettyIo = ExclusionRule(organization = "io.netty", artifact = "netty-all")
val excludeNettyOrg = ExclusionRule(organization = "io.netty")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i find this name confusing, but this is not really important

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, will change

@jacek-lewandowski
Copy link

+1

and shiro.

Revert akka downgrade (since now we are able to use newer one.
Previously we wera unable to use newer once because of sbt-assebly bug
akka/akka#21596)

 Please enter the commit message for your changes. Lines starting
Add explicit closing timeout for spark ctx shutdown
@jtgrabowski jtgrabowski merged commit 9dc546f into dse-2.2 Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants