-
Notifications
You must be signed in to change notification settings - Fork 0
DSP-13836 bump versions of cassandra driver and netty #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f075aa6
to
a2111be
Compare
withouth this change, tar file contained directory "." with desired content. Now content is placed at the root of the archive.
lazy val mesos = sys.env.getOrElse("MESOS_VERSION", "1.0.0-2.0.89.ubuntu1404") | ||
lazy val metrics = "2.2.0" | ||
lazy val netty = "4.0.42.Final" | ||
lazy val netty = "4.0.44.Final" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.1 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DSP-14152
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment - we probably need to bump Netty to 4.1 since we do it for Spark. This may follow bumping Akka to some newer release which works with Netty 4.1.
project/ExclusionRules.scala
Outdated
val excludeScalaTest = ExclusionRule(organization = "org.scalatest") | ||
val excludeScala = ExclusionRule(organization = "org.scala-lang") | ||
val excludeNettyIo = ExclusionRule(organization = "io.netty", artifact = "netty-all") | ||
val excludeNettyOrg = ExclusionRule(organization = "io.netty") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i find this name confusing, but this is not really important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, will change
+1 |
and shiro. Revert akka downgrade (since now we are able to use newer one. Previously we wera unable to use newer once because of sbt-assebly bug akka/akka#21596) Please enter the commit message for your changes. Lines starting
Add explicit closing timeout for spark ctx shutdown
No description provided.