Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] risc0-build: update build function to look at new location for cpp toolchain #2017

Closed
SchmErik opened this issue Jun 24, 2024 · 1 comment · Fixed by #2028
Closed

[Feature] risc0-build: update build function to look at new location for cpp toolchain #2017

SchmErik opened this issue Jun 24, 2024 · 1 comment · Fixed by #2028
Labels
enhancement New feature or request

Comments

@SchmErik
Copy link
Contributor

Feature

The new rzup utility will store the cpp toolchain under ~/.rzup. Modify the risc0-build functionality to look at this location first before checking the old location. This allows cargo build to function regardless of if the user chooses cargo risczero install or the new rzup to install their toolchain.

Motivation

This is needed for the new rzup to supersede cargo risczero install. This is a temporary measure

Implementation

Change the risc0_data() function to return the path in ~/.rzup if it exists. otherwise, return the old path.
@SchmErik SchmErik added the enhancement New feature or request label Jun 24, 2024
@linear Linear
Copy link

linear bot commented Jun 24, 2024

ZKVM-463 [Feature] risc0-build: update build function to look at new location for cpp toolchain

@SchmErik SchmErik mentioned this issue Jun 25, 2024
Merged
SchmErik added a commit that referenced this issue Jul 4, 2024
@SchmErik
risc0-build: change risc0_data to support revamped rzup (#2028)
6f416bb 
rzup will store toolchains in the ~/.rzup directory. Check if this new
directory does not exist, fallback to the old directory.

closes: #2017
SchmErik added a commit that referenced this issue Jul 9, 2024
@SchmErik
risc0-build: change risc0_data to support revamped rzup (#2028)
1fbf93d 
rzup will store toolchains in the ~/.rzup directory. Check if this new
directory does not exist, fallback to the old directory.

closes: #2017
SchmErik added a commit that referenced this issue Jul 10, 2024
@SchmErik
risc0-build: change risc0_data to support revamped rzup (#2028)
d47b3d2 
rzup will store toolchains in the ~/.rzup directory. Check if this new
directory does not exist, fallback to the old directory.

closes: #2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

risc0-build: change risc0_data to support revamped rzup risc0/risc0
1 participant
@SchmErik