Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OP-V and OP-P to base opcode map #1094

Closed
wants to merge 1 commit into from
Closed

Add OP-V and OP-P to base opcode map #1094

wants to merge 1 commit into from

Conversation

a4lg
Copy link
Contributor

@a4lg a4lg commented Aug 13, 2023

"V" extension corresponding new base opcode OP-V (0b1010111) is now ratified and opcode using OP-P (0b1110111) is approved for the vector cryptography extensions.

This PR reflects new base opcodes.

Note that OP-V part is an AsciiDoc port of #862.
OP-P part is new in this PR (I didn't notice at the first time but vector cryptography extensions use instructions with OP-P).

@Nelson1225
Copy link

Seems like OP_V and OP_P haven't been updated in the spec, they are still reserved. However, OP_V was already used for vector in the binutils. So it would great if spec can clarify 0x57 is OP_V, and 0x77 is OP_P :-)

@a4lg
Copy link
Contributor Author

a4lg commented Aug 15, 2023

Reference: Vector Crypto Specification (v1.0.0-rc2)

Appendix A: Crypto Vector Cryptographic Instructions
OP-P (0x77) Crypto Vector instructions except Zvbb and Zvbc

lists 21 instructions (with 11 funct6 values) with OP-P.

@a4lg
Copy link
Contributor Author

a4lg commented Sep 7, 2023

@aswaterman
Reminder and a question.
Should I separate OP-P changes to avoid arguments of P/V allocation? I thought using the name OP-P is already approved because (near ratification) vector cryptography documentation uses OP-P... but tell me if not.

@aswaterman
Copy link
Member

Yeah, I don't want to accept this PR as-is, but I can accept a PR that adds only OP-V.

@a4lg
Copy link
Contributor Author

a4lg commented Sep 7, 2023

Understood. I'll keep this open but make a plain port of #862.

"V" extension corresponding new base opcode OP-V (0b1010111) is now ratified
and opcode using OP-P (0b1110111) is approved for the vector cryptography
extensions.

This commit reflects new base opcodes.

Signed-off-by: Tsukasa OI <research_trasio@irq.a4lg.com>
@aswaterman
Copy link
Member

I'm going to close this with the expectation something similar will be reopened once a P spec is closer to the finish line.

@aswaterman aswaterman closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants