You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We just opened #26532 on hard-coded dev credentials in the S3 e2e test helpers (e2e_test/s3/file_sink.py / file_source.py — hummockadmin literals).
We want to sanity-check the value before anyone invests time: these are meant only for a local MinIO / dev fixture and are not a production vulnerability — purely a test/secrets-hygiene cleanup. Is the suggested approach (externalizing to a git-ignored or preset fixture config) aligned with how the team wants to handle test credentials? Happy to help with the PR if it's deemed worth it.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
We just opened #26532 on hard-coded dev credentials in the S3 e2e test helpers (
e2e_test/s3/file_sink.py/file_source.py—hummockadminliterals).We want to sanity-check the value before anyone invests time: these are meant only for a local MinIO / dev fixture and are not a production vulnerability — purely a test/secrets-hygiene cleanup. Is the suggested approach (externalizing to a git-ignored or preset fixture config) aligned with how the team wants to handle test credentials? Happy to help with the PR if it's deemed worth it.
All reactions