This repository has been archived by the owner on Mar 23, 2022. It is now read-only.
[WIP] Upgrade xunit to 2.0, install xunit VS test runner NuGet package #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kendaleiv
changed the title
|
This needs to be rebased on top of #17. |
|
Rebased. |
| </PropertyGroup> | ||
| <Error Condition="!Exists('..\..\packages\xunit.core.2.0.0\build\portable-net45+win+wpa81+wp80+monotouch+monoandroid+Xamarin.iOS\xunit.core.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\xunit.core.2.0.0\build\portable-net45+win+wpa81+wp80+monotouch+monoandroid+Xamarin.iOS\xunit.core.props'))" /> | ||
| <Error Condition="!Exists('..\..\packages\xunit.runner.visualstudio.2.0.0\build\net20\xunit.runner.visualstudio.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\xunit.runner.visualstudio.2.0.0\build\net20\xunit.runner.visualstudio.props'))" /> | ||
| </Target> |
There was a problem hiding this comment.
May you please remove this block (lines 67-73) from the commit? I know that the package automatically added them, but they're pointless since we use automatic restore instead of the old MSBuild-based package restore.
|
Was this build supposed to fail? |
khalidabuhakmeh
pushed a commit
to khalidabuhakmeh/automation-sql
that referenced
this pull request
Mar 26, 2015
The default suffix generator uses DateTime.Now.Ticks, this is normally ok, until you run in parallel with a unit test runner that decides to put all the localdb files in the same directory. This can cause an overlap that leads to test failures. The suffix generator allows you to inject a unique suffix based on any generator you can think of: Guid, DateTime, etc. ritterim#16
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to demonstrate the xunit 2.0 issues that occur with the VS test runner NuGet package when using
LocalDb. It doesn't resolve the issue. This PR also doesn't currently update the build script, either.