Windows fixes and logging #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhancement: Add logging upon missing file or package - Testing: Tighten/Loosen size expectations for testing on Windows - Testing: Check Windows - Testing: Run tests serially to avoid errors due to overlapping package/file changes - npm: Update `babel/runtime`, pacote, terser deps. and devDeps
brettz9
added
bug
dependencies
|
I think this is ready for review. As far as the two messages with "Expected — Waiting for status to be reported " you might take a look at https://github.community/t/github-actions-pull-requests-always-include-some-outdated-checks/16157/4 |
ritz078
approved these changes
Jun 30, 2020
|
Thanks for the fix. I have published a new version. |
|
Thanks and apologies it took me some time to get to it. But it is I think good we can now both test on Windows and also avoid the issues our test cases provided with the previous concurrent testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babel/runtime, pacote, terser deps. and devDeps