fix(fe): links in new window #2992
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
commit: |
Graphite Automations"Test" took an action on this PR • (09/25/25)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
NathanFlurry
approved these changes
Sep 26, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
### TL;DR Added `target="_blank"` and `rel="noopener noreferrer"` to Discord and GitHub links in the sidebar. ### What changed? - Removed unused icon imports (`faCheck` and `faTriangleExclamation`) - Added `target="_blank"` and `rel="noopener noreferrer"` attributes to the Discord and GitHub links in the sidebar to ensure they open in new tabs ### How to test? 1. Navigate to any page with the sidebar 2. Click on either the Discord or GitHub links 3. Verify that they open in a new tab instead of replacing the current page ### Why make this change? This improves user experience by allowing users to visit external resources without losing their current context in the application. The `rel="noopener noreferrer"` attribute also adds security by preventing the new tab from accessing the window.opener property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added
target="_blank"andrel="noopener noreferrer"to Discord and GitHub links in the sidebar.What changed?
faCheckandfaTriangleExclamation)target="_blank"andrel="noopener noreferrer"attributes to the Discord and GitHub links in the sidebar to ensure they open in new tabsHow to test?
Why make this change?
This improves user experience by allowing users to visit external resources without losing their current context in the application. The
rel="noopener noreferrer"attribute also adds security by preventing the new tab from accessing the window.opener property.