Skip to content

fix(guard): proxy routing errors through ws #3006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(guard): proxy routing errors through ws #3006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions out/errors/guard.target_changed.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/core/guard/core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ futures-util.workspace = true
futures.workspace = true
http-body-util.workspace = true
http-body.workspace = true
http.workspace = true
# TODO: Make this use workspace version
hyper = { version = "1.6.0", features = ["full", "http1", "http2"] }
hyper-tungstenite.workspace = true
Expand Down
12 changes: 9 additions & 3 deletions packages/core/guard/core/src/errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,10 @@ pub struct NoRouteTargets;
"guard",
"retry_attempts_exceeded",
"Retry attempts exceeded.",
"All {attempts} retry attempts failed (max: {max_attempts})."
"All {attempts} retry attempts failed."
)]
pub struct RetryAttemptsExceeded {
pub attempts: u32,
pub max_attempts: u32,
}

#[derive(RivetError, Serialize, Deserialize)]
Expand All @@ -74,7 +73,14 @@ pub struct ConnectionError {
#[error(
"guard",
"websocket_service_unavailable",
"WebSocket service unavailable.",
"WebSocket service unavailable."
)]
pub struct WebSocketServiceUnavailable;

#[derive(RivetError, Serialize, Deserialize)]
#[error(
"guard",
"target_changed",
"WebSocket target changed, retry not possible."
)]
pub struct WebSocketTargetChanged;
Loading
Loading