-
Notifications
You must be signed in to change notification settings - Fork 41
chore(core): simplify config #1350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+180
−187
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,38 +1,22 @@ | ||
import type { Hono } from "hono"; | ||
import { z } from "zod"; | ||
import { ClientConfigSchema } from "@/client/config"; | ||
import { getEnvUniversal } from "@/utils"; | ||
|
||
export const ConfigSchema = z | ||
export const EngingConfigSchema = z | ||
.object({ | ||
app: z.custom<Hono>().optional(), | ||
endpoint: z | ||
.string() | ||
.default( | ||
() => | ||
getEnvUniversal("RIVET_ENGINE") ?? | ||
getEnvUniversal("RIVET_ENDPOINT") ?? | ||
"http://localhost:6420", | ||
), | ||
token: z | ||
.string() | ||
.optional() | ||
.transform((val) => val ?? getEnvUniversal("RIVET_TOKEN")), | ||
pegboardEndpoint: z.string().optional(), | ||
namespace: z | ||
.string() | ||
.default(() => getEnvUniversal("RIVET_NAMESPACE") ?? "default"), | ||
runnerName: z | ||
.string() | ||
.default(() => getEnvUniversal("RIVET_RUNNER") ?? "rivetkit"), | ||
// TODO: Automatically attempt to determine key by common env vars (e.g. k8s pod name) | ||
/** Unique key for this runner. Runners connecting a given key will replace any other runner connected with the same key. */ | ||
runnerKey: z | ||
.string() | ||
.default( | ||
() => getEnvUniversal("RIVET_RUNNER_KEY") ?? crypto.randomUUID(), | ||
), | ||
|
||
/** How many actors this runner can run. */ | ||
totalSlots: z.number().default(100_000), | ||
}) | ||
// We include the client config since this includes the common properties like endpoint, namespace, etc. | ||
.merge(ClientConfigSchema) | ||
.default({}); | ||
|
||
export type InputConfig = z.input<typeof ConfigSchema>; | ||
export type Config = z.infer<typeof ConfigSchema>; | ||
export type EngineConfig = z.infer<typeof EngingConfigSchema>; | ||
export type EngineConfigInput = z.input<typeof EngingConfigSchema>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the schema name
EngingConfigSchema
which should beEngineConfigSchema
. This needs to be corrected for consistency with how it's referenced elsewhere in the codebase.Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.