Skip to content

Include TS declarations from generated sources in node_modules_package #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

Include TS declarations from generated sources in node_modules_package #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c3562c
Include TS declarations in ts_library `JsInfo`
nevadaperry Jun 18, 2025
125f77a
Include TsInfo in `nodejs_modules_package` transitive files instead
nevadaperry Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion nodejs/rules.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ load("@rules_pkg//pkg:providers.bzl", "PackageFilegroupInfo", "PackageFilesInfo"
load("@rules_pkg//pkg:tar.bzl", "pkg_tar")
load("//commonjs:providers.bzl", "CjsInfo", "create_globals", "gen_manifest", "package_path")
load("//javascript:providers.bzl", "JsInfo")
load("//typescript:providers.bzl", "TsInfo")
load("//util:path.bzl", "nearest", "relativize", "runfile_path")
load(":providers.bzl", "NodejsInfo", "NodejsRuntimeInfo")

Expand Down Expand Up @@ -372,6 +373,7 @@ def nodejs_modules(name, deps, **kwargs):
def _nodejs_modules_package_impl(ctx):
deps_cjs = [target[CjsInfo] for target in ctx.attr.deps]
deps_js = [target[JsInfo] for target in ctx.attr.deps]
deps_ts = [target[TsInfo] for target in ctx.attr.deps if (TsInfo in target)]
label = ctx.label
links_cjs = [target[CjsInfo] for target in ctx.attr.links]
workspace = ctx.workspace_name
Expand All @@ -390,7 +392,7 @@ def _nodejs_modules_package_impl(ctx):
package_paths_nonempty = {}

transitive_files = depset(
transitive = [js_info.transitive_files for js_info in deps_js],
transitive = [info.transitive_files for info in (deps_js + deps_ts)],
)
files_map = {}
for file in transitive_files.to_list():
Expand Down