-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cutter freezes when scrolling disassembly #3328
Comments
If you scroll at moderate speed do you see a bunch of warnings in the builtin console widget? |
log:
also now i'm not so sure that wayland is related, i'm now getting freezes in X when trying to open the same executable again. backtrace:
the application freezes there. |
Ok this looks like combination of two problems:
|
I cannot reproduce it on Debian. And the PCRE2 and NixOS issues don't mention problems with JIT anywhere. |
@praschke Setting up NixOS takes pretty long for me (installing qt6/5 doesn't work and more). And I don't know unfortunately, when I will find time to take care of it. So if you are willing, you can test the following patches, which disables JIT for the regex engine. If they do work, it means NixOS has problems with the PCRE2 JIT as well. We shoud report this in NixOS/nixpkgs#300056 in this case. And than see how they'd like to solve it. Diffs They are for diff --git a/meson.build b/meson.build
index a8153a2ee5..787cbfae06 100644
--- a/meson.build
+++ b/meson.build
@@ -197,7 +197,7 @@ endif
# Handle PCRE2
cpu_jit_supported = [ 'aarch64', 'arm', 'mips', 'mips64', 'ppc', 'ppc64', 'riscv32', 'riscv64', 's390x', 'x86', 'x86_64' ]
-pcre2_jit_supported = target_machine.cpu_family() in cpu_jit_supported and cc.get_id() != 'tcc' and target_machine.system() != 'darwin'
+pcre2_jit_supported = false
if pcre2_jit_supported
add_project_arguments(['-DSUPPORTS_PCRE2_JIT'], language: 'c')
endif diff --git a/subprojects/packagefiles/pcre2/meson.build b/subprojects/packagefiles/pcre2/meson.build
index b40ea85740..f3ee7a02ed 100644
--- a/subprojects/packagefiles/pcre2/meson.build
+++ b/subprojects/packagefiles/pcre2/meson.build
@@ -60,18 +60,6 @@ cpu_jit_supported = [ 'aarch64', 'arm', 'mips', 'mips64', 'ppc', 'ppc64', 'riscv
# tcc doesn't support the MSVC asm syntax PCRE2 uses (`__asm { ... }`).
# Darwin kernel not as well, because of forbidden wx memory.
# It is used in the JIT compiler code.
-if cc.get_id() != 'tcc' and target_machine.cpu_family() in cpu_jit_supported and target_machine.system() != 'darwin'
- libpcre2_c_args += ['-DSUPPORT_JIT']
- pcre2_files += ['src/pcre2_jit_compile.c']
-endif
-
-if target_machine.system() == 'openbsd'
- # jit compilation fails with "no more memory" if wx allocations are allowed.
- libpcre2_c_args += ['-DSLJIT_WX_EXECUTABLE_ALLOCATOR']
-elif target_machine.system() == 'netbsd'
- # jit compilation fails with "no more memory" if wx allocations are allowed.
- libpcre2_c_args += ['-DSLJIT_PROT_EXECUTABLE_ALLOCATOR']
-endif
pcre2_includes = [
include_directories('.'), |
Multiple users reported problems related to this. See: rizinorg/cutter#3220 rizinorg/cutter#3328
Environment information
Describe the bug
Scrolling too quickly in the disassembly freezes Cutter.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Cutter doesn't freeze.
Additional context
The freeze only occurs on Wayland. On Xwayland it functions normally.
backtrace:
Attached file:
vpatch.zip
The text was updated successfully, but these errors were encountered: