Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcre2: JIT not enabled in 10.43 #300056

Open
JustinAzoff opened this issue Mar 29, 2024 · 1 comment · Fixed by #300565
Open

pcre2: JIT not enabled in 10.43 #300056

JustinAzoff opened this issue Mar 29, 2024 · 1 comment · Fixed by #300565
Labels
0.kind: bug Something is broken

Comments

@JustinAzoff
Copy link

Describe the bug

A bug in pcre2 configure scripts cause the JIT not to be enabled. This makes apps that use pcre2 heavily, like suricata, extremely slow.

Steps To Reproduce

Steps to reproduce the behavior:

$ nix build -L 'nixpkgs#pcre2' --rebuild
...
pcre2> pcre2-10.43 configuration summary:
...
pcre2>     Enable JIT compiling support ....... : no

or

$ nix shell 'nixpkgs#pcre2' -c pcre2grep --help|grep jit
      --no-jit                 ignored: this pcre2grep does not support JIT

Expected behavior

JIT should be enabled

Additional context

This was fixed upstream 6 days ago:

PCRE2Project/pcre2@ab7f871

As part of digging into this issue I looked to see how this may be broken on other distributions, and noticed that debian takes a different approach, instead of using auto, they do this:

#enable JIT only on architectures that support it (see pcre2jit.3)
ifneq ($(filter amd64 armel armhf arm64 i386 mips mipsel mips64el powerpc ppc64 ppc64el riscv64 s390x, $(DEB_HOST_ARCH)),)
deb_maint_conf_args +=--enable-jit
else
deb_maint_conf_args +=--disable-jit
endif

So I'm not sure if the preferred approach here would be to include the upstream patch, or use the more explicit --enable-jit option on supported platforms.

Notify maintainers

@ttuegel

Add a 👍 reaction to issues you find important.

@JustinAzoff JustinAzoff added the 0.kind: bug Something is broken label Mar 29, 2024
@JustinAzoff
Copy link
Author

noticed i linked to the commit, the MR might be more useful: PCRE2Project/pcre2#396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant