Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch enums access to RzBaseType API #1010

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Switch enums access to RzBaseType API #1010

merged 1 commit into from
Apr 13, 2021

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Apr 13, 2021

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the rizin book with the relevant information (if needed)

Detailed description

Some of the rz_type_*enum*() functions were accessing directly to SDB. Here I converted these to RzBaseType API use.

Test plan

CI is green

Closing issues

Partly addresses #368

@XVilka XVilka added the RzType label Apr 13, 2021
@XVilka XVilka force-pushed the rztypes branch 2 times, most recently from 8cd730d to 37fef16 Compare April 13, 2021 12:29
@XVilka XVilka merged commit 9c71f7b into dev Apr 13, 2021
@XVilka XVilka deleted the rztypes branch April 13, 2021 14:52
@XVilka XVilka mentioned this pull request Apr 14, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thestr4ng3r thestr4ng3r thestr4ng3r approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@wargio wargio Awaiting requested review from wargio wargio is a code owner

Assignees
No one assigned
Labels
command merge-when-green RzCore RzType
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XVilka @thestr4ng3r