FEATURE: use CPAN::Meta::Merge to preserve all meta fragments while merging

[karenetheridge]

cc @dagolden @Leont

[dagolden]

This looks good to me (though GH says there are conflicts).

I'd like to see it it applied and released, as that will help resolve some long-standing metadata manipulation goals.

[karenetheridge]

On Tue, Jul 29, 2014 at 07:40:31AM -0700, David Golden wrote:

This looks good to me (though GH says there are conflicts).
I'd like to see it it applied and released, as that will help resolve some long-standing metadata manipulation goals.

I'll rebase that to the 5.020 release.

[karenetheridge]

rebased.

[rjbs]

thanks, applied

[rjbs]

I've reverted this. When it was applied and installed and I tried to build Dist-Zilla itself, I got:

Can't merge attribute resources.resources.homepage at /Users/rjbs/.plenv/versions/21.3/lib/perl5/site_perl/5.21.3/Dist/Zilla.pm line 524.

I have not investigated.

[Leont]

That error message sounds like CPAN::Meta::Merge is getting confused. I should investigate that.

[Leont]

I've reverted this. When it was applied and installed and I tried to build Dist-Zilla itself, I got:

Can't merge attribute resources.resources.homepage at /Users/rjbs/.plenv/versions/21.3/lib/perl5/site_perl/5.21.3/Dist/Zilla.pm line 524.

The error is because both [MetaResources] and [Github] are setting the resources.homepage field to different values. CPAN::Meta::Merge is correctly concluding that it can't make sense out of this.

The resources.resources.homepage is incorrect though, that should be resources.homepage. I just pushed a fix to CPAN::Meta::Merge for that, along with a better error message for the collision itself.

[karenetheridge]

On Thu, Oct 23, 2014 at 12:08:26PM -0700, Leon Timmermans wrote:

The error is because both [MetaResources] and [Github] are setting the resources.homepage field to different values. CPAN::Meta::Merge is correctly concluding that it can't make sense out of this. This error message could be improved.

fwiw - I use [GithubMeta] for this.

[rjbs]

merged!

get it?