-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allOf support #1380
Add allOf support #1380
Conversation
Bug: When using allOf, with one of the options is an array with Playground reproduction here (check the boxes "Omit extra data" and "Live omit") |
This bug was fixed in 4eccffa. |
package.json
Outdated
@@ -46,6 +46,7 @@ | |||
"@babel/runtime-corejs2": "^7.4.5", | |||
"ajv": "^6.7.0", | |||
"core-js": "^2.5.7", | |||
"json-schema-merge-allof": "git+https://github.com/mokkabonna/json-schema-merge-allof.git#e43d0f2227476e069667358b86d0e8c91b50a777", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a git dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It links to my PR here (mokkabonna/json-schema-merge-allof#5), which makes sure that mergeAllOf can be called with deep: false
and thus only merges a top-level allOf
. It's not strictly required, but I guess it's a performance improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's not strictly required, I'll just remove it since that's better than depending on a git dependency.
This reverts commit 6728977.
Aside from tests and docs, is this feature complete as-is? If not, how can I help out? |
@erunion tests, docs, and a playground example. Feel free to help out with either -- just let me know on this PR! |
@epicfaace I can help out with a playground example. |
Hello all, I would be really interested in having this merged. Is there anything I can do to help knowing little to nothing about React? |
Remaining todos:
|
Hello All, this is holding up an important fix very far downstream elsewhere - is there any hope of seeing this PR resolved any time soon? Is there anything a novice can do to help? Thanks! |
Looks good to me, we can merge if you think it is good |
Thanks everyone! |
@epicfaace could you please fix the conflicts? We're so close! |
@epicfaace any chance of the conflicts being resolved soon? |
Reasons for making this change
Support for allOf -- fixes #52, fixes #1237, fixes #1378
Todo:
Checklist