[GH-2090] [fluent-ui] fix: Text inputs render with invalid attribute #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttribute TextWidget generated `<input type="string" ... >` HTML which is invalid as per https://html.spec.whatwg.org/multipage/input.html#states-of-the-type-attribute `<input type="text" ... >` would be apropriate. The generation of invalid HTML results in undefined behaviour. I got on the trail of the issue, because [testing-library/user-event](https://github.com/testing-library/user-event#typeelement-text-options) acted in strange ways. This PR results in the generation of valid HTML and updates the tests. fix rjsf-team#2090
mdornseif
changed the title
|
@mdornseif would you mind contributing a similar fix to #2088, #2089, and #2087? Would really appreciate it! |
|
@epicfaace sure, "if time permits" :-) - thanks for your work on the awesome rjsf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
TextWidget generated
<input type="string" ... >HTML which is invalid as per
https://html.spec.whatwg.org/multipage/input.html#states-of-the-type-attribute
<input type="text" ... >would be apropriate.The generation of invalid HTML results in undefined behaviour.
I got on the trail of the issue, because
testing-library/user-event
acted in strange ways.
This PR results in the generation of valid HTML and updates the tests.
fix #2090
If this is related to existing tickets, include links to them as well.
Checklist