Reimplement #1755 and and #2460 in new Form.tsx #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
requested review from
epicfaace,
jimmycallin,
jacqueswho and
nickgros
heath-freenome
force-pushed
the
reimplement-1755
branch
from
ef56522
to
9f4a7d4
Compare
- Reimplement two fixes related to `onChange` in the new `Form.tsx` - rjsf-team#1755 fixes the calling of the proper `onChange` during props update - rjsf-team#2460 fixes race condition on calling `onChange` after setState.
heath-freenome
force-pushed
the
reimplement-1755
branch
from
9f4a7d4
to
f8cfb23
Compare
8 tasks
nickgros
approved these changes
Aug 27, 2022
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Aug 27, 2022
…sf-team#3052) - Reimplement two fixes related to `onChange` in the new `Form.tsx` - rjsf-team#1755 fixes the calling of the proper `onChange` during props update - rjsf-team#2460 fixes race condition on calling `onChange` after setState.
This was referenced Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #1708 and #513
onChangein the newForm.tsxonChangeduring props updateonChangeafter setState.Checklist
npm run test:updateto update snapshots, if needed.