Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the uischema options are on the options object, not options.props #3910

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pksorensen
Copy link
Contributor

Reasons for making this change

-- How can this even have been approved and merged together without anyone notice.

Easily seen in playground also, just add ui:widget textarea and ui:rows to a field and nothing happens with fluentui theme

If this is related to existing tickets, include links to them as well. Use the syntax fixes #[issue number] (ex: fixes #123).

If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit

Checklist

I just added the fix in the online editor to bring attention to the bug - well see if test fails

-- How can this even have been approved and merged together without anyone notice.

Easily seen in playground also, just add ui:widget textarea and ui:rows to a field and nothing happens with fluentui theme
@heath-freenome
Copy link
Member

@pksorensen Is there an associated issue for this? Also, you'll need to fix the formatting to get the tests to run

@pksorensen
Copy link
Contributor Author

Sorry, i think it went stale. We kinda made our own base components back then to integrate into our solution and i did not get time to revisit this. Cant remember if i misunderstood / not fully understood the design of rjsf when i made the pr in the first go around. Feel free to close this if this just was me who was having an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants