Status improvements - add file system #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPIFFS size info in System view
use FSInfo struct for esp8266
|
@raomin Thx for the PR. I've made some minor changes in this branch. Main thing is using the terminology "fs" rather than "spiffs", figured that made sense as SPIFFS is deprecated and is going to be replaced by LittleFS on esp8266. Because the FS.h abstraction is so differnent between the two platforms, I can't think of a way to get this working how I'd like. Ideally I'd like SettingsService to take a pointer to the FS instance rather than reference the singleton. The intention here was that users could provide any FS implementation to be used as the storage for the framework (and SD card for instance). I've left a comment in the code to that effect, hopefully the FS.h implementations will have feature parity at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.