Don't remove mappings when using a custom handler #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When changing `g:ag_*handler` it would only make sense to remove the quickfix/location list mappings if the new handler didn't use one of those lists. Otherwise removing the mappings is (imo) a separate decision from writing your own handler, so it would be best not to mix the two.
losingkeys
added a commit
that referenced
this pull request
Jan 10, 2014
…dlers Don't remove mappings when using a custom handler
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing
g:ag_*handlerit would only make sense to remove thequickfix/location list mappings if the new handler didn't use one of
those lists.
Otherwise removing the mappings is (imo) a separate decision from
writing your own handler, so it would be best not to mix the two.