Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lo-res screen rolled to the left #38

Closed
juri74 opened this issue Mar 6, 2016 · 35 comments
Closed

Lo-res screen rolled to the left #38

juri74 opened this issue Mar 6, 2016 · 35 comments
Assignees
Labels

Comments

@juri74
Copy link

juri74 commented Mar 6, 2016

Hello!
configuration: mist with lastest firmware/core (1.2 fix). 68020, AGA, 2MB CHIP, 24MB FAST, KICK 3.1, TURBO=none >>> 15 KHZ output <<<

how to clearly see this bug in action:

Execute Deluxepaint and open a 320x256 at any colours deep. (i tested 32 and 256 colors)
Draw a vertical line at the far left of the screen, you will see the same line appear to the far right of the screen, the line you draw an the left looks very thin (like half pixel wide)

the interesting thing is that there is something wrong with OCS/ECS chipset too, but this time it happen on HIRES screens and in the opposite way:
to see this one in action, boot to workbench and open any window. then move the window to the rightmost possible and you will see last pixel column of the window displayed on the far left of the screen.
i can provide pictures if you want
Juri

@rkrajnc rkrajnc self-assigned this Mar 7, 2016
@rkrajnc
Copy link
Owner

rkrajnc commented Mar 7, 2016

Hi,

yes, pictures would help, thanks!

@juri74
Copy link
Author

juri74 commented Mar 10, 2016

hi, here are the pictures
AGA low res bug -> https://goo.gl/photos/5P6FAAFBSvmaSQxs8
OCS/ECS hi res bug -> https://goo.gl/photos/6h7yd8TFLqKzoG4W9
thanks

@rkrajnc
Copy link
Owner

rkrajnc commented Mar 10, 2016

Ah, that again :) I was afraid this was some completely new problem ;)

This is the cause of the bitplane shifter, which was upgraded with shres scrolling for AGA. It seems the default delays I set up are not correct - the default AGA screen is moved to far to the right, and vice versa for the ECS. It seems the extra shift will have to be bypassed in ECS mode, and the AGA moved to its proper location. The scroller resolution (and thus offset) is also dependent on the bitplane resolution, so it is possible this problem could only be present for certain resolution / chipset combinations.

I'll fix this as soon as I have some time. Thanks for the photos!

@AmigaIstMiST
Copy link

Maybe related (or duplicate) to
mist-devel/mist-binaries#9

@rkrajnc
Copy link
Owner

rkrajnc commented Apr 14, 2016

Hi @AmigaIstMiST,

the dot on the screen is most probably a separate issue. I didn't see this myself yet, but I'll check if I can reproduce it.

@rkrajnc rkrajnc added the bug label Apr 14, 2016
@AmigaIstMiST
Copy link

Hi @rkrajnc ,

I am not a HW developer, but a question comes in my mind:
your are combining AGA and OCS/ECS in one core, but weren't the A1200 and the the A500/600 two different graphic architectures? Why not two separate cores, one for A1200 and one for A500/600, wouldn't this be easier?

@rkrajnc
Copy link
Owner

rkrajnc commented Apr 14, 2016

Yes, AGA and ECS were different architectures, but AGA is heavily (mostly) based on ECS, and it is also very compatible with ECS.

Since the current design already has support for both, it would be lots of (tedious) work to split ECS from AGA. It would also mean maintaining two code bases, which means fixing common bugs in both of them, which is even more tedious, boring work. As far as I'm concerned, I'll keep it like it is at least until a new (hypothetical) CPU core is made with 32 bit external bus (which would then be used exclusively for the AGA core).

@AmigaIstMiST
Copy link

One more question, I don't want to keep you away from working on the Amiga core :-) :
But hasn't the actual 68020 CPU already a 32 bit bus? Wikipedia told me, it's a full 32 bit CPU. Or is the current version a "lite" version with 16 bit bus?

@rkrajnc
Copy link
Owner

rkrajnc commented Apr 15, 2016

Yes, the real 68020 has a 32bit bus, but the TG68 CPU core used in minimig does not, which requires some hacks to make it work like in a real AGA Amiga, unfortunately with some side effects that haven't been fixed fully yet.

@sblendorio
Copy link

sblendorio commented Aug 1, 2016

Hi, I confirm that strange behavior in Lo-Res mode (Lo-res screen rolled to the left)

@kowoba
Copy link

kowoba commented Aug 2, 2016

Funny, I noticed that too tonight, while playing Worms DC :)

@sblendorio
Copy link

The same can be notice playing Monkey Island

@juri74
Copy link
Author

juri74 commented Dec 21, 2016

hello @rkrajnc ,
i noticed google removed my pictures for some reason, please tell me if you still need them,
i will take new ones and try to use different web space to hold them on
thanks

@rkrajnc
Copy link
Owner

rkrajnc commented Dec 21, 2016

Hi,

I've seen this problem myself, so I know what to look for :) But if you want, feel free to update the pictures, so that other people can see them and know that this is an already known problem.

@jmorgon
Copy link

jmorgon commented Jan 14, 2017

an example in AmigaDOS window

15726390_922476544451257_1016880913726987630_n

@kowoba
Copy link

kowoba commented Jan 17, 2017

Here is what I see in Worms DC - I do not know if this is the same bug or not, but thought I'd just post it :) Some columns from the "far left" show up on the "far right".

img_1574
img_1575

@sblendorio
Copy link

sblendorio commented Jan 17, 2017 via email

@AmigaIstMiST
Copy link

Hi @rkrajnc ,

just an idea: is it be possible to do a "ECS only" build without this bug, until you have found the problem?
Or is it more complicated? Most games+programs are OCS/ECS only, anyway.

@uchristo
Copy link

uchristo commented Jun 8, 2017

Any further thoughts on that issue? Can you point out, where to change the delay so I could compile the core by myself to try out....

@rkrajnc
Copy link
Owner

rkrajnc commented Jun 9, 2017

The bitplane shifter is here: https://github.com/rkrajnc/minimig-mist/blob/master/rtl/minimig/denise_bitplane_shifter.v

The problem is how to change the delay, so it will work OK for both AGA and ECS modes.

@uchristo
Copy link

uchristo commented Jun 9, 2017

So..... the bitplane Shifter should be able to read out the value of module
https://github.com/rkrajnc/minimig-mist/blob/master/rtl/minimig/minimig.v
Line 382: wire [4:0] chipset_config; //chipset features selection
?

@AmigaIstMiST
Copy link

AmigaIstMiST commented Aug 13, 2017

20170813_112101

This is the AGA Version of Simon The Sorcerer. I am willing to give a "thumb up" to the person who will fix this :-).

@uchristo
Copy link

uchristo commented Oct 13, 2017

as I got my OSSC yesterday, motivation has returned as well.
I had a look into the Code again ( has been approx 10 years since I last coded [more or less successfully] in VHDL...). As I understand, Denise is instantiated in https://github.com/rkrajnc/minimig-mist/blob/master/rtl/minimig/minimig.v, Line 659 and following. Config (AGA/ECS) is written in Line 678(for ECS, highest 1 Bit set of 5 Bit Register) or 679(for AGA, uper 2 Bits from 5 Bit Config-Register ).
module denise_bitplane_shifter (...) should be able to read these values (.clk, .clk7_en and so on are used in https://github.com/rkrajnc/minimig-mist/blob/master/rtl/minimig/denise_bitplane_shifter.v starting in line 29 as well).
Am I correct?
Then it should be possible to roll the AGA-Screen back to the right. But I really don't understand that code :-(

@juri74
Copy link
Author

juri74 commented Oct 31, 2017

any news on this problem? thanks

@rkrajnc
Copy link
Owner

rkrajnc commented Nov 3, 2017

No (good) solution yet, sorry.

@uchristo
Copy link

uchristo commented Jan 3, 2018

Whilst there's no good solution, does a quick-and-dirty solution exist?

Did you think about #38 (comment) ?

@kowoba
Copy link

kowoba commented Jan 3, 2018

Yeah, a temporary fix that only works with AGA is much better than no fix at all :)

@sblendorio
Copy link

sblendorio commented Jan 5, 2018 via email

@uchristo
Copy link

No description provided.

@uchristo
Copy link

Hm.... any thoughts on #38 (comment) ? I'd really like to help

@AmigaIstMiST
Copy link

Fixed in V 1.2.3. I think, this bug could be closed.

@kowoba
Copy link

kowoba commented May 30, 2018

1.2.3?? Wow, what a wonderful day this is! 😃

@uchristo
Copy link

uchristo commented Jun 5, 2018

Seems fixed. Had a quick look at SimonTheSorcererAGA yesterday. Thank you very much!

@juri74
Copy link
Author

juri74 commented Jul 23, 2018

yes i tested and look fixed, closing

@juri74 juri74 closed this as completed Jul 23, 2018
@kowoba
Copy link

kowoba commented Sep 24, 2018

In what commit was this fixed? Or does it only exist in the 1.2.3 beta release? Where are the sources?
As far as I can tell, the fix has not been committed, and hence this issue should not have been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants