Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failure to find plantuml.jar due to white space in file path #9

Closed
jstrin opened this issue Jun 4, 2020 · 5 comments
Closed

failure to find plantuml.jar due to white space in file path #9

jstrin opened this issue Jun 4, 2020 · 5 comments

Comments

@jstrin
Copy link

jstrin commented Jun 4, 2020

When calling plantuml.jar, plot.plantuml the file path passed to system2 is not wrapped in quotes. resulting in the error "Unable to access jarfile C:/Users/FirstName"

It appears to be at lines 73 to 76 in the plot.plantuml.R file. I ran a local version updating the lines to wrap the path in double quotes which seemed to resolve the issue:

   cmd <- paste0(
     '-jar "',
     system.file("jar", "plantuml.jar", package = "plantuml"), '"'
  ) 
@rkrug rkrug closed this as completed in 80317db Jun 5, 2020
@rkrug
Copy link
Owner

rkrug commented Jun 5, 2020

Thanks for reporting.

You are right - I assume, you have spaces in your path to the jar file?

Just pushed a fix to GitHub on master.

@jstrin
Copy link
Author

jstrin commented Jun 5, 2020

Thanks! just installed the updated version and works as expected.

Yes, I am using a work computer and IT set up user names with space between first and last name resulting in this issue recurring; I'm getting pretty good at spotting it.

@rkrug
Copy link
Owner

rkrug commented Jun 5, 2020

Perfect - thanks for letting me know, that it works on windows.

If you are using this for a project which is open, I could add a link to it in the readme.

@jstrin
Copy link
Author

jstrin commented Jun 5, 2020

At the moment, I am exploring ways of improving the documentation practices for my team. If we end up using plantuml for any public projects, I will be sure to let you know. On a related note, I may end up putting together instructions for installing Graphviz on windows machines; would those be of use to you for package documentation?

@rkrug
Copy link
Owner

rkrug commented Jun 9, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants